Closed Bug 965057 Opened 8 years ago Closed 8 years ago

Fix zoom menu fallout from bug 691614

Categories

(SeaMonkey :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.26

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file, 1 obsolete file)

We need to port the new properties that bug 691614 added to Firefox's tabbrowser.xml so that the Zoom menu starts working in the browser again.

The new properties were also added to browser.xml so nothing needs to be done for the Zoom menu in MailNews.
Attached patch Proposed patch (obsolete) — Splinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8367011 - Flags: review?(philip.chee)
Comment on attachment 8367011 [details] [diff] [review]
Proposed patch

> +      <property name="isSyntheticDocument"
> +                onget="return this.mCurrentBrowser.docShellIsActive;"
> +                readonly="true"/>
Er? Really?
Flags: needinfo?(neil)
Attached patch Proposed patchSplinter Review
Bah, too much copy-and-paste, and that one was different because it doesn't have a setter and I forgot to fix up the getter.
Attachment #8367011 - Attachment is obsolete: true
Attachment #8367011 - Flags: review?(philip.chee)
Attachment #8367180 - Flags: review?(philip.chee)
Flags: needinfo?(neil)
Comment on attachment 8367180 [details] [diff] [review]
Proposed patch

r=me. I assume you've tested this.
Attachment #8367180 - Flags: review?(philip.chee) → review+
Pushed comm-central changeset efa3650fd3b7 (with the wrong bug#, oops...)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.26
Attachment #8367180 - Attachment description: 965057.diff → Proposed patch
You need to log in before you can comment on or make changes to this bug.