Fix zoom menu fallout from bug 691614

RESOLVED FIXED in seamonkey2.26

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: neil, Assigned: neil)

Tracking

unspecified
seamonkey2.26

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We need to port the new properties that bug 691614 added to Firefox's tabbrowser.xml so that the Zoom menu starts working in the browser again.

The new properties were also added to browser.xml so nothing needs to be done for the Zoom menu in MailNews.
(Assignee)

Comment 1

5 years ago
Created attachment 8367011 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #8367011 - Flags: review?(philip.chee)

Comment 2

5 years ago
Comment on attachment 8367011 [details] [diff] [review]
Proposed patch

> +      <property name="isSyntheticDocument"
> +                onget="return this.mCurrentBrowser.docShellIsActive;"
> +                readonly="true"/>
Er? Really?
Flags: needinfo?(neil)
(Assignee)

Comment 3

5 years ago
Created attachment 8367180 [details] [diff] [review]
Proposed patch

Bah, too much copy-and-paste, and that one was different because it doesn't have a setter and I forgot to fix up the getter.
Attachment #8367011 - Attachment is obsolete: true
Attachment #8367011 - Flags: review?(philip.chee)
Attachment #8367180 - Flags: review?(philip.chee)
Flags: needinfo?(neil)

Comment 4

5 years ago
Comment on attachment 8367180 [details] [diff] [review]
Proposed patch

r=me. I assume you've tested this.
Attachment #8367180 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 5

5 years ago
Pushed comm-central changeset efa3650fd3b7 (with the wrong bug#, oops...)
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.26
(Assignee)

Updated

5 years ago
Attachment #8367180 - Attachment description: 965057.diff → Proposed patch
You need to log in before you can comment on or make changes to this bug.