965114 - Exception when displaying a menu of options

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Steve Fink [:sfink] [:s:]]

Starting with hg 2.7.1, any bzexport command that tried to display a menu of options would instead give:

  File "/home/njn/moz/bzexport/__init__.py", line 154, in choose_value
    return prompt_menu(ui, desc, list(options), message = message)
  File "/home/njn/moz/bzexport/__init__.py", line 132, in prompt_menu
    choice = prompt_manychoice(ui, message, prompts)
  File "/home/njn/moz/bzexport/__init__.py", line 112, in prompt_manychoice
    return ui.promptchoice(message, prompts, len(prompts)-1)
  TypeError: promptchoice() takes at most 3 arguments (4 given)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Stop using ui.promptchoice

Looks like 2.7.1 changed the parameters of ui.promptchoice to something uglier, eg (example from the documentation):

  "would you like fries with that (Yn)? $$ &Yes $$ &No"

Rather than try to be compatible across versions, I say just stop trying to use ui.promptchoice entirely.

Comment 2

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/f1b2724ebc97