Let tokenserver use new hosted verifier at https://verifier.accounts.firefox.com

VERIFIED FIXED

Status

Cloud Services
Server: Token
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We need to support generation numbers and new-style assertion formats in tokenserver, and the existing persona.org verifier doesn't do that.  There's a hot new verifier at https://verifier.accounts.firefox.com that we should use instead.

This patch updates the tokenserver RemoteVerifier implementation to use it.  Because of API and format changes, it's easier to implement just what we need here rather than bringing the whole of PyBrowserID up to spec.  We should push this down into PyBrowserID at some point in the future.
(Assignee)

Comment 1

4 years ago
Created attachment 8367123 [details] [diff] [review]
tokenserver-new-verifier.diff
Assignee: nobody → rfkelly
Attachment #8367123 - Flags: review?(telliott)
(Assignee)

Updated

4 years ago
Blocks: 963209
(Assignee)

Updated

4 years ago
Blocks: 961253
/me wonders if we need a Dev and/or Stage ticket to match this one for Prod.
Whiteboard: [qa+]
(Assignee)

Comment 3

4 years ago
They'll all get it by default as the new version of the code rolls out
Comment on attachment 8367123 [details] [diff] [review]
tokenserver-new-verifier.diff

Review of attachment 8367123 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is fine. I'm a little worried about having external verification as part of this process along with such short-duration tokens, but we're obvioulsy not going to do local verification at this point.
Attachment #8367123 - Flags: review?(telliott) → review+
(Assignee)

Comment 5

4 years ago
*nod*

Some additional discussion on potential paths forward in Bug 956222.
(Assignee)

Comment 6

4 years ago
https://github.com/mozilla-services/tokenserver/commit/6ff5aabd80273528b45d870172917ea927d2c129
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
I think this has been pushed to Prod as well as Stage.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.