965157 - window._isChromeDebugger might not be useful anymore

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

...since the switch to the Browser Toolbox.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Still used in a few places, haven't bothered looking into specifics of what it is used for:

http://dxr.mozilla.org/mozilla-central/search?q=_isChromeDebugger&case=true

Comment 2

[Victor Porof [:vporof][:vp]]

That's the point, it *is* used, but it's always false, so it's irrelevant.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Remove standalone chrome debugger code paths

Woo, deleting code! :D

Try: https://tbpl.mozilla.org/?tree=Try&rev=bb06cb3b8c85

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8382757 [details] [diff] [review]
Remove standalone chrome debugger code paths

Review of attachment 8382757 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I'll want to test this manually as well to make sure we're not missing anything.
Have you also manually tested?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Victor Porof [:vporof][:vp] from comment #4)
> Looks good, but I'll want to test this manually as well to make sure we're
> not missing anything.
> Have you also manually tested?

Yes, I tried starting debugging sessions for web and chrome content, as well as the browser toolbox.  Also, I tried setting breakpoints in the script actor from the browser toolbox.

Everything seems to work as expected so far.  Did you want to test more yourself before landing this?

Comment 6

[Victor Porof [:vporof][:vp]]

Nah, everything seems fine. Ship it!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/5b68edd09793

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b68edd09793