window._isChromeDebugger might not be useful anymore

RESOLVED FIXED in Firefox 30

Status

P3
normal
RESOLVED FIXED
5 years ago
4 months ago

People

(Reporter: vporof, Assigned: jryans)

Tracking

unspecified
Firefox 30

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
...since the switch to the Browser Toolbox.
Still used in a few places, haven't bothered looking into specifics of what it is used for:

http://dxr.mozilla.org/mozilla-central/search?q=_isChromeDebugger&case=true
(Reporter)

Comment 2

5 years ago
That's the point, it *is* used, but it's always false, so it's irrelevant.
Priority: -- → P3
(Assignee)

Comment 3

5 years ago
Created attachment 8382757 [details] [diff] [review]
Remove standalone chrome debugger code paths

Woo, deleting code! :D

Try: https://tbpl.mozilla.org/?tree=Try&rev=bb06cb3b8c85
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Attachment #8382757 - Flags: review?(vporof)
(Reporter)

Comment 4

5 years ago
Comment on attachment 8382757 [details] [diff] [review]
Remove standalone chrome debugger code paths

Review of attachment 8382757 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I'll want to test this manually as well to make sure we're not missing anything.
Have you also manually tested?
Attachment #8382757 - Flags: review?(vporof) → review+
(Assignee)

Comment 5

5 years ago
(In reply to Victor Porof [:vporof][:vp] from comment #4)
> Looks good, but I'll want to test this manually as well to make sure we're
> not missing anything.
> Have you also manually tested?

Yes, I tried starting debugging sessions for web and chrome content, as well as the browser toolbox.  Also, I tried setting breakpoints in the script actor from the browser toolbox.

Everything seems to work as expected so far.  Did you want to test more yourself before landing this?
Flags: needinfo?(vporof)
(Reporter)

Comment 6

5 years ago
Nah, everything seems fine. Ship it!
Flags: needinfo?(vporof)
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/5b68edd09793
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/5b68edd09793
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 30

Updated

5 years ago
QA Whiteboard: [qa-]

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.