Closed Bug 965173 Opened 10 years ago Closed 10 years ago

Nexus 4 B2G builds failing with " device/lge/mako/bluetooth/bdroid_buildcfg.h:24:33: fatal error: b2g_bdroid_buildcfg.h: No such file or directory"

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed, b2g-v1.4 fixed)

RESOLVED FIXED
1.3 C3/1.4 S3(31jan)
blocking-b2g 1.3+
Tracking Status
b2g-v1.3 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: emorley, Assigned: ben.tian)

References

Details

I've just had to hide the Nexus 4 B2G builds on TBPL, since it an unknown checkin to one of the many unlisted repos used as part of the build, is causing failures of form:

https://tbpl.mozilla.org/php/getParsedLog.php?id=33728690&tree=B2g-Inbound
{
00:16:01     INFO -  Export includes file: external/bluetooth/bluedroid/hci/Android.mk -- out/target/product/mako/obj/SHARED_LIBRARIES/libbt-hci_intermediates/export_includes
00:16:01     INFO -  Export includes file: external/bluetooth/bluedroid/utils/Android.mk -- out/target/product/mako/obj/SHARED_LIBRARIES/libbt-utils_intermediates/export_includes
00:16:01     INFO -  Export includes file: external/bluetooth/bluedroid/gki/Android.mk -- out/target/product/mako/obj/STATIC_LIBRARIES/libbt-brcm_gki_intermediates/export_includes
00:16:01     INFO -  Export includes file: external/bluetooth/bluedroid/bta/Android.mk -- out/target/product/mako/obj/STATIC_LIBRARIES/libbt-brcm_bta_intermediates/export_includes
00:16:01     INFO -  Export includes file: external/bluetooth/bluedroid/stack/Android.mk -- out/target/product/mako/obj/STATIC_LIBRARIES/libbt-brcm_stack_intermediates/export_includes
00:16:01     INFO -  Export includes file: external/tinyxml2/Android.mk -- out/target/product/mako/obj/STATIC_LIBRARIES/libtinyxml2_intermediates/export_includes
00:16:01     INFO -  Import includes file: out/target/product/mako/obj/SHARED_LIBRARIES/bluetooth.default_intermediates/import_includes
00:16:01     INFO -  target thumb C++: bluetooth.default <= external/bluetooth/bluedroid/main/../btif/src/btif_config_util.cpp
00:16:02     INFO -  /builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.7/bin/../lib/gcc/arm-linux-androideabi/4.7/../../../../arm-linux-androideabi/bin/as: /lib64/libz.so.1: no version information available (required by /builds/slave/b2g_b2g-in_nexus-4_dep-0000000/build/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.7/bin/../lib/gcc/arm-linux-androideabi/4.7/../../../../arm-linux-androideabi/bin/as)
00:16:02     INFO -  target thumb C: bluetooth.default <= external/bluetooth/bluedroid/main/../btif/src/bluetooth.c
00:16:02     INFO -  In file included from external/bluetooth/bluedroid/main/../include/bt_target.h:44:0,
00:16:02     INFO -                   from external/bluetooth/bluedroid/main/../bta/include/bta_api.h:29,
00:16:02     INFO -                   from external/bluetooth/bluedroid/main/../btif/include/btif_common.h:24,
00:16:02     INFO -                   from external/bluetooth/bluedroid/main/../btif/include/btif_api.h:33,
00:16:02     INFO -                   from external/bluetooth/bluedroid/main/../btif/src/bluetooth.c:44:
00:16:02     INFO -  device/lge/mako/bluetooth/bdroid_buildcfg.h:24:33: fatal error: b2g_bdroid_buildcfg.h: No such file or directory
00:16:02     INFO -  compilation terminated.
00:16:02     INFO -  make: *** [out/target/product/mako/obj/SHARED_LIBRARIES/bluetooth.default_intermediates/../btif/src/bluetooth.o] Error 1
}

Bug 899969 was supposed to mean that any changes to the non-gecko/gaia repos were visible in the form of bot commits to the manifests (eg: https://hg.mozilla.org/integration/b2g-inbound/rev/e0d2a1828aed), however there are no non-gaia changes listed, so at least some repos must still be circumventing the manifest.

TBPL results (incl retriggers in progress):
https://tbpl.mozilla.org/?tree=B2g-Inbound&jobname=b2g_b2g-inbound_nexus-4_dep&fromchange=159ead273215&tochange=e0d2a1828aed

The requirements for unhiding the Nexus 4 builds are:
* Fixing this failure.
* Ensuring whatever repo's checkin broke this is controlled by the manifest.

Unhiding will be taken care of in a bug in the TBPL component (will file shortly).
Depends on: 899969
Blocks: 965174
This has to be from bug 951565.
Blocks: 951565
The odd thing is that https://hg.mozilla.org/releases/mozilla-aurora/rev/7fec994c5e4b added the config file that this is complaining about.
Well, that created the header, but is it properly exported for use?
My assumption is that this broke Mako builds because the header's not actually being exported?

https://hg.mozilla.org/releases/mozilla-aurora/file/7fec994c5e4b/dom/bluetooth/moz.build
Bug 899969 is working as expected after all, removing dependency.
No longer depends on: 899969
I just reverted bug 951565, so hopefully this goes green on the next Bumper Bot commit to b2g-inbound.
Thank you :-)

To give more context for those not following bug 899969, the manifest changed was missed by me earlier, had it been spotted, we could have just backed out instead of hiding.

Bug 872628 would help make the "what else changed in other repos, incl file lists" question quicker to answer, as well as making it harder to miss changes in the future :-)
No longer blocks: 965174
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #7)
> I just reverted bug 951565, so hopefully this goes green on the next Bumper
> Bot commit to b2g-inbound.

I think the patch of bug 957949 is been added (dom/bluetooth/bluedroid/b2g_bdroid_buildcfg.h).

https://github.com/mozilla-b2g/device-mako/commit/59877c64bb3665441547f9e7a9a990394393bffc
It provides INCLUDE_PATH.

I think this is the dependency :(
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #5)
> My assumption is that this broke Mako builds because the header's not
> actually being exported?
> 
> https://hg.mozilla.org/releases/mozilla-aurora/file/7fec994c5e4b/dom/
> bluetooth/moz.build
Whenever 'external/bluetooth/bluedroid' was been built, it searches device/lge/mako/bluetooth/bdroid_buildcfg.h and bdroid_buildcfg.h includes b2g_bdroid_buildcfg.h from $(GECKO_PATH)/dom/bluetooth/bluedroid.
Nexus 4 builds are green again. The system works! \m/

(In reply to Shawn Huang [:shuang] [:shawnjohnjr](CNY leave from 1/30 ~ 2/4) from comment #10)
> I think the patch of bug 957949 is been added
> (dom/bluetooth/bluedroid/b2g_bdroid_buildcfg.h).

(In reply to Shawn Huang [:shuang] [:shawnjohnjr](CNY leave from 1/30 ~ 2/4) from comment #11)
> Whenever 'external/bluetooth/bluedroid' was been built, it searches
> device/lge/mako/bluetooth/bdroid_buildcfg.h and bdroid_buildcfg.h includes
> b2g_bdroid_buildcfg.h from $(GECKO_PATH)/dom/bluetooth/bluedroid.

I'm confused by that because bug 957949 was landed on trunk and Aurora and both burned. But I also don't know about our build system enough to know if we need an explicit EXPORT on it or not. I'll leave it to the devs to decide if they want to reopen bug 957949 or file a follow-up to figure out what's wrong here.
Assignee: nobody → btian
Blocks: 957949
Status: NEW → RESOLVED
blocking-b2g: --- → 1.3?
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
It might be related to GECKO_PATH is not been defined, based on comments from mwu.
https://bugzilla.mozilla.org/show_bug.cgi?id=951565#c23
blocking-b2g: 1.3? → 1.3+
You need to log in before you can comment on or make changes to this bug.