965276 - Set Travis command line to 10s

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

Do this for now to stop the default one kicking in after `is_element_present` and in future see if we can bring it down to Marionette's default 5 by tuning the waits.

Comment 1

[Zac C (:zac)]

Attachment: github pr

This is not strictly necessary but it just makes sure the timeout is at least stable at 10s and we don't get any unexpected stuff if it gets set back to the Marionette default of 5s somehow.

I promise to aim to reduce it to 5s in the future :)

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8367342 [details] [review]
github pr

r+ because it will not have any negative impact, but a short clarification:

Without this, implicit wait timeouts will be 10 seconds [1], and will be set back to 10 seconds after is_element_present [2]. Any explicit waits (using the new Wait class) will default to 5 seconds. Page loads will default to 30 seconds.

With this, all timeouts are set to 10 seconds. I actually this this patch is unnecessary, but as said above, it won't cause any issues and 10 seconds is a reasonable timeout.

[1] https://github.com/mozilla-b2g/gaia/blob/78dda57ce4b5e5eb862a370a4fb994d1f0b1c5a3/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L870
[2] https://github.com/mozilla-b2g/gaia/blob/78dda57ce4b5e5eb862a370a4fb994d1f0b1c5a3/tests/python/gaia-ui-tests/gaiatest/apps/base.py#L115

Comment 3

[Zac C (:zac)]

Thanks! 
merged:

https://github.com/mozilla-b2g/gaia/commit/801bb65388584a1e00d153c826c72adedb8b0125