Closed Bug 965343 Opened 8 years ago Closed 8 years ago

Upgrade to Mozrunner 5.32

Categories

(Testing Graveyard :: Mozmill, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [mozmill-2.0.4+])

Attachments

(1 file, 1 obsolete file)

We need the fixes for Mozrunner 5.32 for Mozmill 2.0.4. So lets get its version bumped up.
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #8367400 - Flags: review?(dave.hunt)
Comment on attachment 8367400 [details] [diff] [review]
Patch v1

Review of attachment 8367400 [details] [diff] [review]:
-----------------------------------------------------------------

LGMT

::: mozmill/mozmill/extension/components/handlers.js
@@ +57,5 @@
>  }
>  
>  
> +const errorRegEx = /\[.*(Error|Exception).*(chrome|resource):\/\/(mozmill|jsbridge).*/i;
> +

Nit: as this const is no longer used in the if condition below, is it still being used somewhere else? If not it could be removed.
Attached patch patch v2Splinter Review
Actually the last patch was busted. It should have only contained the version bump for mozrunner. So here the corrected one.
Attachment #8367400 - Attachment is obsolete: true
Attachment #8367400 - Flags: review?(dave.hunt)
Attachment #8367447 - Flags: review?(drno)
Comment on attachment 8367447 [details] [diff] [review]
patch v2

Review of attachment 8367447 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8367447 - Flags: review?(drno) → review+
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.