Upgrade to Mozrunner 5.32

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Details

(Whiteboard: [mozmill-2.0.4+])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
We need the fixes for Mozrunner 5.32 for Mozmill 2.0.4. So lets get its version bumped up.
(Assignee)

Comment 1

5 years ago
Created attachment 8367400 [details] [diff] [review]
Patch v1
Attachment #8367400 - Flags: review?(dave.hunt)
Comment on attachment 8367400 [details] [diff] [review]
Patch v1

Review of attachment 8367400 [details] [diff] [review]:
-----------------------------------------------------------------

LGMT

::: mozmill/mozmill/extension/components/handlers.js
@@ +57,5 @@
>  }
>  
>  
> +const errorRegEx = /\[.*(Error|Exception).*(chrome|resource):\/\/(mozmill|jsbridge).*/i;
> +

Nit: as this const is no longer used in the if condition below, is it still being used somewhere else? If not it could be removed.
(Assignee)

Comment 3

5 years ago
Created attachment 8367447 [details] [diff] [review]
patch v2

Actually the last patch was busted. It should have only contained the version bump for mozrunner. So here the corrected one.
Attachment #8367400 - Attachment is obsolete: true
Attachment #8367400 - Flags: review?(dave.hunt)
Attachment #8367447 - Flags: review?(drno)
Comment on attachment 8367447 [details] [diff] [review]
patch v2

Review of attachment 8367447 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8367447 - Flags: review?(drno) → review+
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.