965343 - Upgrade to Mozrunner 5.32

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

We need the fixes for Mozrunner 5.32 for Mozmill 2.0.4. So lets get its version bumped up.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Patch v1

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8367400 [details] [diff] [review]
Patch v1

Review of attachment 8367400 [details] [diff] [review]:
-----------------------------------------------------------------

LGMT

::: mozmill/mozmill/extension/components/handlers.js
@@ +57,5 @@
>  }
>  
>  
> +const errorRegEx = /\[.*(Error|Exception).*(chrome|resource):\/\/(mozmill|jsbridge).*/i;
> +

Nit: as this const is no longer used in the if condition below, is it still being used somewhere else? If not it could be removed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: patch v2

Actually the last patch was busted. It should have only contained the version bump for mozrunner. So here the corrected one.

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8367447 [details] [diff] [review]
patch v2

Review of attachment 8367447 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

https://github.com/mozilla/mozmill/commit/a2b0c6156c8c509a330cf3729880e8e39e6fe774 (master)
https://github.com/mozilla/mozmill/commit/36bf65690829c43c95058554be274f9354c12589 (hotfix-2.0)