965380 - [Search] Abstract local result rendering

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Kevin Grandon :kgrandon]

It would be nice if we can abstract the current places formatting for reuse for other types of results.

Also need to take some CSS changes from bug 961422 here.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8367440 [details] [review]
Github pull request

Hey Dale - this is essentially the last patch to get everything landed in master. Would you happen to have a few minutes to review this?

The bulk of this patch is abstracting rendering logic into the base provider class. By doing this we should be able to style individual providers using CSS where necessary. Please let me know what you think.

Comment 3

[Dale Harvey (:daleharvey)]

Comment on attachment 8367440 [details] [review]
Github pull request

So I think this is only half way to what we want to do, search is going to want to provide plain non marked up data (so we can do brainy type things) and the html generated at the render stage, but as much as we can change the html generation and do custom styling via css the better

Comment 4

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/63da947a065384b13c8565ddf70667d444764987

Comment 5

[Kevin Grandon :kgrandon]

(In reply to Dale Harvey (:daleharvey) from comment #3)
> Comment on attachment 8367440 [details] [review]
> Github pull request
> 
> So I think this is only half way to what we want to do, search is going to
> want to provide plain non marked up data (so we can do brainy type things)
> and the html generated at the render stage, but as much as we can change the
> html generation and do custom styling via css the better

Ah, right. I suppose we should probably axe the HtmlHelper.createHighlightHTML calls within the provider as well. Perhaps we can pass in some flag (highlight=1) to that will trigger highlights of the search term?