965560 - sidebar toolbarbutton shows even when there is no sidebar to show

Status: RESOLVED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

[aurora] The toolbar button shows when you install a provider that does not have a sidebar.  One such provider uses only a status button, in which case two buttons appear in the toolbar, one for the status panel, one for the sidebar.  Following patch prevents showing the sidebar toolbarbutton if no sidebar providers exist.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: only show button when we have sidebar providers

Comment 2

[Shane Caraveo (:mixedpuppy)]

aurora try:

https://tbpl.mozilla.org/?tree=Try&rev=55ad7a9d657f

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8368921 [details] [diff] [review]
only show button when we have sidebar providers

Assuming this doesn't beat uplift, would need beta approval instead...basically need this in fx28.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): socialapi toolbarbutton
User impact if declined: a second misleading button icon for users of some providers.
Testing completed (on m-c, etc.): aurora fx28
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Since it hasn't landed on central yet, might need to land post-merge, I'll carry over the approval nom if necessary and tracking to ensure this lands in 28.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8368921 [details] [diff] [review]
only show button when we have sidebar providers

Cf comment #4 from Lukas and since the merge has been done, aurora does not need the uplift while it is now needed for the beta.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0adf847ac2d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/f0adf847ac2d