Closed Bug 965607 Opened 6 years ago Closed 6 years ago

browser-fxaccounts.js should show doorhangers only if it's the most recent non-popup browser window

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: ttaubert, Assigned: ttaubert)

Details

Attachments

(1 file)

browser-fxaccounts.js manages per-window UI like the widget contained in the Australis menu. At the same time it's also responsible for showing doorhangers when starting sync or to notify about errors.

We shouldn't show doorhangers for every open window but instead for the most recent non-popup browser window.
Comment on attachment 8368074 [details] [diff] [review]
0002-Bug-965607-Show-FxA-doorhangers-only-for-the-most-re.patch

Review of attachment 8368074 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-fxaccounts.js
@@ +30,5 @@
>        FxAccountsCommon.ONLOGOUT_NOTIFICATION
>      ];
>    },
>  
> +  // The set of topics that only the active window should handle.

this looks magic - I think a comment indicating you are avoiding a reference to FxAccountsCommon in the top-level scope would be good
Attachment #8368074 - Flags: review?(mhammond) → review+
Backed out:

https://hg.mozilla.org/integration/fx-team/rev/97b90c0dc96c
Whiteboard: [fixed-in-fx-team]
Re-landed as I'm pretty sure this wasn't causing the orange:

https://hg.mozilla.org/integration/fx-team/rev/48ec899c90a0
https://hg.mozilla.org/mozilla-central/rev/48ec899c90a0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.