965607 - browser-fxaccounts.js should show doorhangers only if it's the most recent non-popup browser window

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Tim Taubert [:ttaubert] (inactive)]

browser-fxaccounts.js manages per-window UI like the widget contained in the Australis menu. At the same time it's also responsible for showing doorhangers when starting sync or to notify about errors.

We shouldn't show doorhangers for every open window but instead for the most recent non-popup browser window.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-965607-Show-FxA-doorhangers-only-for-the-most-re.patch

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8368074 [details] [diff] [review]
0002-Bug-965607-Show-FxA-doorhangers-only-for-the-most-re.patch

Review of attachment 8368074 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser-fxaccounts.js
@@ +30,5 @@
>        FxAccountsCommon.ONLOGOUT_NOTIFICATION
>      ];
>    },
>  
> +  // The set of topics that only the active window should handle.

this looks magic - I think a comment indicating you are avoiding a reference to FxAccountsCommon in the top-level scope would be good

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/1471e8762222

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

Backed out:

https://hg.mozilla.org/integration/fx-team/rev/97b90c0dc96c

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Re-landed as I'm pretty sure this wasn't causing the orange:

https://hg.mozilla.org/integration/fx-team/rev/48ec899c90a0

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/48ec899c90a0