Closed
Bug 965630
Opened 10 years ago
Closed 10 years ago
Output BSOs include the internal-use-only "collection" key
Categories
(Cloud Services Graveyard :: Server: Sync, defect)
Cloud Services Graveyard
Server: Sync
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: rfkelly, Assigned: rfkelly)
Details
(Whiteboard: [qa?])
Attachments
(2 files)
|
1.33 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.81 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
Example fetch here: https://gist.github.com/ncalexan/8701009
|
Assignee | |
Updated•10 years ago
|
Summary: Output BSO's include the internal-use-only "collection" key → Output BSOs include the internal-use-only "collection" key
|
|
Assignee | |
Comment 1•10 years ago
|
||
Not showing on dev endpoint == probably a memcached-backend-specific bug
|
|
Assignee | |
Comment 2•10 years ago
|
||
It also included "payload_size" and "userid".
|
|
Assignee | |
Comment 3•10 years ago
|
||
I'm going to commit the attached for rollout to unblock client work, but there's probably a more nuanced solution here.
|
||
Updated•10 years ago
|
Whiteboard: [qa?]
|
|
Assignee | |
Comment 4•10 years ago
|
||
OK, here's what a proper solution should look like. This changed both SQL and Memcached backend to avoid mutating the input items directly. Instead they make a copy of just the fields they need and mutate those instead.
Attachment #8369279 -
Flags: review?(telliott)
|
|
Assignee | |
Updated•10 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
|
||
Updated•10 years ago
|
Attachment #8369279 -
Flags: review?(telliott) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
https://github.com/mozilla-services/server-syncstorage/commit/9e7c19459a5f84d2a6a8dc4cd860ab4c84c94451
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•1 year ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•