Output BSOs include the internal-use-only "collection" key

VERIFIED FIXED

Status

Cloud Services
Server: Sync
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa?])

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
Example fetch here:

https://gist.github.com/ncalexan/8701009
(Assignee)

Updated

4 years ago
Summary: Output BSO's include the internal-use-only "collection" key → Output BSOs include the internal-use-only "collection" key
(Assignee)

Comment 1

4 years ago
Not showing on dev endpoint == probably a memcached-backend-specific bug
(Assignee)

Comment 2

4 years ago
It also included "payload_size" and "userid".
(Assignee)

Comment 3

4 years ago
Created attachment 8367747 [details] [diff] [review]
sync15-remove-extra-bso-fields.diff

I'm going to commit the attached for rollout to unblock client work, but there's probably a more nuanced solution here.
Whiteboard: [qa?]
(Assignee)

Comment 4

4 years ago
Created attachment 8369279 [details] [diff] [review]
sync15-dont-mutate-items.diff

OK, here's what a proper solution should look like.  This changed both SQL and Memcached backend to avoid mutating the input items directly.  Instead they make a copy of just the fields they need and mutate those instead.
Attachment #8369279 - Flags: review?(telliott)
(Assignee)

Updated

4 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Attachment #8369279 - Flags: review?(telliott) → review+
(Assignee)

Comment 5

4 years ago
https://github.com/mozilla-services/server-syncstorage/commit/9e7c19459a5f84d2a6a8dc4cd860ab4c84c94451
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Verified in code.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.