965649 - Don't link full page width in search results.

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

It's just noise--and in a tight space, at that. We have a nice, fat row highlight to promise clickability.

Comment 1

[Erik Rose [:erik][:erikrose]]

I don't see any row highlight, so this bug isn't entirely true. Decide what to do, if anything. For one thing, I'm not thrilled that you can click the whole width of the page but there's no visual indication of it. Sometimes I click out in whitespace just to defocus things, and I'm surprised when I'm whisked off to somewhere else.

Comment 2

[Erik Rose [:erik][:erikrose]]

Let's keep the mouseover underline, but let's make it so only the text--not the whole width of the page--is clickable. Defocusing the query field is a common need when you've just done a search-as-you-type search and then want to Page Down through the results. You should be able to click any old whitespace on the page to do it. There's plenty of target area in most lines of code to make extending the click area unnecessary.

Comment 3

[Erik Rose [:erik][:erikrose]]

Plus, full-width linking hobbled highlighting as explained in bug 1002791.

Comment 5

[Torehan Sharman]

Hi there! I think I fixed this. I created a pull request:
https://github.com/mozilla/dxr/pull/355

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/1f9d4f1ab343068818044f05fef6d3a42eba29ef
Merge patch to not link full page width on results. Fix bug 965649. Close #355.

Comment 7

[[github robot]]

Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/1f9d4f1ab343068818044f05fef6d3a42eba29ef
Merge patch to not link full page width on results. Fix bug 965649. Close #355.