965650 - Make the "no results" banner more subtle.

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

Right now, it's the flashiest thing on the site. I guess if we wanted to encourage and reward people to do no-results searches... ;-)

Comment 1

[Erik Rose [:erik][:erikrose]]

Might as well do the Direct Results one while you're at it. They look similar.

Comment 2

[Erik Rose [:erik][:erikrose]]

I also see we're repeating the "No results" message 5 times in the codebase. That's inexcusbale; we should factor it out somehow, perhaps into a Jinja macro.

The Direct results thing was taken care of in bug 970489.

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/734afc620cfe01e7ac2eefca3fba2adde5ba5824
Make the no-results message more visually subtle. Fix bug 965650.

Also change the class name: the only use of this template left is saying "no results". A future bug will factor out all the repetition and improve the message itself.

Comment 4

[Erik Rose [:erik][:erikrose]]

Moved the DRY part into bug 973113.