965666 - You can open the Switch Tree and Filters menus at once

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

Click one of the menus. Then click the other. They both stay open at once. Clicking elsewhere dismisses them both. Oops. :-)

Comment 1

[[github robot]]

Commit pushed to ui at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/12092275f5df1f7838da4f68cc045ebb3918b18f
Factor out menu-hiding in preparation for fixing bug 965666.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/d8ce5414cbc3574a33dd19e5666cf4b83436822a
Adjust pop-up event handling.

This changes three things:
1) A right or middle click on the tree selector (or filter) menu
   no longer dismisses the menu;
2) As a side effect, Bug 965666 is fixed (opening a menu or help or
   the context menu closes any other open pop-up).
3) The Help menu now closes on Escape.

https://github.com/mozilla/dxr/commit/4cd40cc3d096ff7e9763fe6f032f1eac059b7efe
Merge pull request #480 from kleintom/popup_events_updates

Fixes bug #965666.