965771 - validate RTL locale support in gaia-ui tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Ben Kelly [:bkelly, not reviewing]]

In bug 833401 we are fixing right-to-left (RTL) locale support in the settings app.  It would be great if we could get some tests in automation to help prevent this from regressing again in the future.  It seems gaia-ui or perhaps integration tests might be necessary to test this kind of behavior.  Its unclear to me, though, if we have an RTL locale, like arabic, in the default eng build.

Comment 1

[Zac C (:zac)]

We do have Arabic in the engineering build so we can do this.

We can check functionality but Marionette won't be able to validate very well alignment of elements and that kind of visual thing. But we'd definitely be able to catch when something like the back button disappears.

Put this up into P1 because it's test coverage.

Comment 2

[Zac C (:zac)]

Sasha and I discussed this a bit and we decided to start with a copy of test_settings_change_language.py to change the language to Arabic. The test already scrolls back to the main Settings panel which validates the 'back' button functionality and there it validates that the text label has changed aswell.

This is a good (and easy) smoke test and we can add a tighter assertion if there's a specific test case.

Comment 3

[Axel Hecht [:Pike]]

Yuren picked up a patch on pseudo-localization from me, bug 900182, which we should extend to a pseudo-RTL locale, too.

This might be helpful here, too.

zac, how does this test work? I guess that some of the original regressions had things like the back button totally working, just laid out off screen, which broke the functionality. So it might be more of a test "is the back button visible in full, neither off-screen nor overlaid with something else" than "does the back button work".

Comment 4

[Zac C (:zac)]

Axel yes they are very high level UI tests and they are super-sensitive to when elements are off-screen, hidden and so forth (at Gecko-event level and upwards though). They aim to represent the user's capability as best as possible when it comes to interactions like this.
It will fail fast if the back button is off-screen, not displayed or the tap pixel (centrepoint) shrouded by another element.

Comment 5

[akruglov]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16022

Comment 6

[akruglov]

Added test_settings_change_language_rtl.py that is copy of existing test but with Arabic language.

Comment 7

[akruglov]

Comment on attachment 8371291 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16022

test failed. so, there is no need to review pull request at this moment. I will fix it today or tomorrow.

Comment 8

[Florin Strugariu [:Bebe]]

Hi Sasha any updates on this pull?

do you need any help?

Comment 9

[akruglov]

Hi, Bebe.

Yes, the problem here is that test passes when I run it locally on emulator, but fails on Travis.
Is there way to get / build emulator that is used for running tests on Travis?

Comment 10

[Zac C (:zac)]

(In reply to akruglov from comment #9)
> Hi, Bebe.
> 
> Yes, the problem here is that test passes when I run it locally on emulator,
> but fails on Travis.
> Is there way to get / build emulator that is used for running tests on
> Travis?

Yep you can set it all up basically by following the instructions here:
https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/gaia-ui-tests/Gaia_UI_Tests_Run_Tests#Running_tests_using_Travis_for_Gecko_and_Gaia_developers

Comment 11

[akruglov]

Thanks, Zac.

I fixed test, but Travis job errored in `CI_ACTION=marionette_js`.

Comment 12

[Zac C (:zac)]

Comment on attachment 8371291 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16022

langauge is different on device! r? me again after changing the commit.

Comment 13

[Zac C (:zac)]

Comment on attachment 8371291 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16022

r+, just needs a commit squish.

Comment 14

[akruglov]

Squashed.

Comment 15

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/a21462225e6b13f8025b492df4fef51d14d65588