Closed Bug 965804 Opened 6 years ago Closed 6 years ago

Make non-deprecated textures mandatory on OpenGL platforms

Categories

(Core :: Graphics: Layers, defect)

x86_64
All
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: nical, Assigned: nical)

Details

Attachments

(2 files, 2 obsolete files)

Non-deprecated textures are the default on all OpenGL platforms. This means we can already at least remove the following classes:

YCbCrDeprecatedTextureHostOGL
SharedDeprecatedTextureHostOGL
SurfaceStreamHostOGL
DeprecatedTextureClientStreamOGL
DeprecatedTextureClientSharedOGL
DeprecatedTextureClientSharedOGLExternal

But to do that we have to make sure users won't flip the pref back to deprecated textures and try to run non-existent code.
We should just ignore the pref in GL platforms from now on.

More deprecated code will be removable when non-deprecated ContentClient is enabled on B2G and Windows (we are almost there in both cases) and we have something to do about IncrementalContentClient on Mac which still uses some of the deprecated code (non of which is in the above list)
Assignee: nobody → nical.bugzilla
Attachment #8367975 - Flags: review?(milan)
There's probably more.
Comment on attachment 8367975 [details] [diff] [review]
Ignore the pref except on windows

YOU HAVE ALL MY R+'S

(protip -- edit all.js in prefs, and #ifdef XP_WIN the default setting of that pref so that it doesn't show up in about:config either except on windows)
Attachment #8367975 - Flags: superreview+
Attachment #8367975 - Flags: review+
Attachment #8367975 - Flags: feedback+
Actually we should also check that Windows user don't enable GL layers (updated patch).
Attachment #8367975 - Attachment is obsolete: true
Attachment #8367975 - Flags: review?(milan)
Attachment #8368002 - Flags: review?(milan)
Hm, you still have all my r+'s, but what's wrong with GL on windows?  Specifically OMTC + GL compositor.  That path works fine for me -- I'd be happy to do some fixups to continue to make it work.  I don't care about non-OMTC layers, that can die :)
Comment on attachment 8368002 [details] [diff] [review]
Ignore the pref (except on windows if the backend is not OpenGL)

Review of attachment 8368002 [details] [diff] [review]:
-----------------------------------------------------------------

Not a peer, can't give an actual r+, but f+ and really happy about this!

::: gfx/thebes/gfxPlatform.cpp
@@ +307,3 @@
>      mLayersUseDeprecated =
> +        Preferences::GetBool("layers.use-deprecated-textures", true)
> +        && !Preferences::GetBool("layers.prefer-opengl", false);

Are we actually using layers.prefer-opengl preference anywhere else?
Attachment #8368002 - Flags: review?(milan)
Attachment #8368002 - Flags: review?(bas)
Attachment #8368002 - Flags: feedback+
Comment on attachment 8368002 [details] [diff] [review]
Ignore the pref (except on windows if the backend is not OpenGL)

You *still* have all of my reviews.  Check in and remove old code pls!
Attachment #8368002 - Flags: superreview+
Attachment #8368002 - Flags: review+
Given that we're changing trains on Monday, let's remove the code starting next week :)
Attachment #8368002 - Flags: review?(bas) → review+
(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #5)
> Hm, you still have all my r+'s, but what's wrong with GL on windows? 
> Specifically OMTC + GL compositor.  That path works fine for me -- I'd be
> happy to do some fixups to continue to make it work.  I don't care about
> non-OMTC layers, that can die :)

There's nothing wrong, we just want GL on Windows through non-deprecated code rather than deprecated code.
https://hg.mozilla.org/mozilla-central/rev/fb7220123d5a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Please also remove the stuff that can get removed! :)
You need to log in before you can comment on or make changes to this bug.