965806 - test_lockscreen_unlock_to_camera_with_passcode.TestCameraUnlockWithPasscode is failing after Bug 951978

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

This test started to fail after Bug 951978 - (secure-window) [Window Management] Implement Secure Window (for Secure Camera App on Lockscreen)

test_unlock_to_camera_with_passcode (test_lockscreen_unlock_to_camera_with_passcode.TestCameraUnlockWithPasscode) ... ERROR

======================================================================
ERROR: None
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette_client-0.7.3-py2.7.egg/marionette/marionette_test.py", line 143, in run
    testMethod()
  File "/home/florinstrugariu/gaia/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/lockscreen/test_lockscreen_unlock_to_camera_with_passcode.py", line 30, in test_unlock_to_camera_with_passcode
    lock_screen.wait_for_lockscreen_not_visible()
  File "/home/florinstrugariu/gaia/gaia/tests/python/gaia-ui-tests/gaiatest/apps/lockscreen/app.py", line 52, in wait_for_lockscreen_not_visible
    self.wait_for_element_not_displayed(*self._lockscreen_locator)
  File "/home/florinstrugariu/gaia/gaia/tests/python/gaia-ui-tests/gaiatest/apps/base.py", line 90, in wait_for_element_not_displayed
    'Element %s still visible after timeout' % locator)
TimeoutException: TimeoutException: Element lockscreen still visible after timeout
TEST-UNEXPECTED-FAIL | test_lockscreen_unlock_to_camera_with_passcode.py test_lockscreen_unlock_to_camera_with_passcode.TestCameraUnlockWithPasscode.test_unlock_to_camera_with_passcode | 
----------------------------------------------------------------------
Ran 1 test in 75.269s


It looks like the lock screen is detected visible after we tap the camera button


Failing on build: 
Gaia      0bc0e703df197d46dfffb9ac65cb85d2e3e10c4a
Gecko     http://hg.mozilla.org/mozilla-central/rev/bf49e4428906
BuildID   20140130040201
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

Comment 1

[Florin Strugariu [:Bebe]]

Greg  is this expected ? Should we fix the test?

Comment 2

[Zac C (:zac)]

Bebe, if this works manually then the test needs to be updated.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

On my commit, I had left the Travis link to indicate that my patch passed all test jobs, include the Gaia UI test:

https://travis-ci.org/mozilla-b2g/gaia/jobs/17738183

And I found that the test you mentioned was TEST-SKIP. So I don't know whether the test is now set to not skip after my patch (and thus an error occurs), or the test just only be skipped on Travis and make me can't have a clue about this until you now fired the bug.

Comment 4

[Florin Strugariu [:Bebe]]

Greg:
The test is not run on Travis because it opens the camera app (Travis uses a desktop build).

Zac:
The test woks fine manually and the test might need updating.

My question here is is normal for the lockscreen locator (#lockscreen) to be detected visible if we tap the camera icon with a pass key on.

Comment 5

[Zac C (:zac)]

This is probably a Marionette bug then.

Comment 6

[Florin Strugariu [:Bebe]]

Mdas Can you take a look over this issue.

We think it might be a marionette issue

Comment 7

[Florin Strugariu [:Bebe]]

Attachment: pull request

Comment 8

[Zac C (:zac)]

Comment on attachment 8368532 [details] [review]
pull request

r+

Comment 9

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/de07cb92b64b6872735d6e0270fd06390d60a939

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

So...would this bug should be marked as RESOLVED FIXED?

Comment 11

[Zac C (:zac)]

Yes this is Fixed.

We've modified the test case.