Closed Bug 965820 Opened 6 years ago Closed 6 years ago

margin issues on search field dragged into menu

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: madhava, Assigned: mikedeboer)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [Australis:P3])

Attachments

(1 file)

It looks like this now: http://cl.ly/image/2Q0a0w2b0a1P

And it didn't use to.
Whiteboard: [Australis:P3]
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Comment on attachment 8368533 [details] [diff] [review]
Patch v1: re-add margin for the search field in menu panel

Review of attachment 8368533 [details] [diff] [review]:
-----------------------------------------------------------------

This seems somewhat on the high side when placing the item before non-wide items post-customizing, and conversely, while customizing, putting it before a 2-line-labelled small item, it seems quite small (which goes away after customization ends). However, it's clearly better than what we have and the consequences of this will change again once bug 897496 lands, so I think we should take this as at least it's a big improvement.

For bonus points, please add (in the correct place, probably in customizeMode.inc.css, check if we don't already have a rule for this):

#wrapper-search-container[place="panel"] {
  width: @menuPanelWidth@;
}

Although perhaps we should auto-fix a class to the toolbarpaletteitem wrapper for .panel-wide-items and use that... but that's definitely a separate bug.
Attachment #8368533 - Flags: review?(gijskruitbosch+bugs) → review+
remote: https://hg.mozilla.org/integration/fx-team/rev/f16778a1eed8
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f16778a1eed8
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.