Too many thumbnails in the first publish dialog pushes the save button out of usable view

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

(Whiteboard: [mentor=thecount][mentor=mjschranz][good first bug])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Over user testing I saw a project with over 70 thumbnails, which we add automatically.

These thumbnails show up in the first publish dialog, and are above the save button.

This means the save button is no longer usable.

We should consider a horizontally scrollable thumbnail container. Can probably only need to be one thumbnail in height, not sure if we need to stack them.

Other ideas?
(Assignee)

Updated

5 years ago
Whiteboard: [mentor=thecount][mentor=mjschranz][good first bug]
(Assignee)

Updated

5 years ago
Assignee: nobody → scott
(Assignee)

Comment 1

5 years ago
Created attachment 8393650 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/519

Nothing fancy, just don't show all thumbnail previews in the fist save dialog. It's not super important right now but being able to save is.
Attachment #8393650 - Flags: review?(pomax)

Comment 2

5 years ago
Comment on attachment 8393650 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/519

r- because I had the same question that Matt already left in the PR.
Attachment #8393650 - Flags: review?(pomax) → review-
(Assignee)

Comment 3

5 years ago
Comment on attachment 8393650 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/519

Yeah, I think it works quite well.
Attachment #8393650 - Flags: review- → review?(pomax)

Updated

5 years ago
Attachment #8393650 - Flags: review?(pomax) → review+
(Assignee)

Comment 4

5 years ago
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/2bce74eaa866dbb769fc4821f12146e75488ca47
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.