Closed Bug 965882 Opened 6 years ago Closed 6 years ago

Add crash handling to gaia-unit tests in TBPL

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(3 files)

It's needed to comply with the https://wiki.mozilla.org/Sheriffing/Job_Visibility_Policy, and it should be pretty easy to add.
Attachment #8368335 - Flags: review?(ahalberstadt)
Assignee: nobody → jgriffin
Attachment #8368333 - Flags: review?(ahalberstadt) → review+
Attachment #8368335 - Flags: review?(ahalberstadt) → review+
I'll land the mozharness change after the gaia commit propagates to all the trunk gecko trees.
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #5)
> Reverted for TBPL failures.
> https://github.com/mozilla-b2g/gaia/commit/
> f9013a0d20824de7778ce60f824dc4d90b3cff1b
> 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=33895119&tree=B2g-Inbound

This occurred because the gaia_unit mozharness script is installing (outdated) mozbase packages from internal pypi, rather than from the tests.zip that we're already downloading.  I have a fix and I'll test it on ash.
Attachment #8368902 - Flags: review?(ahalberstadt)
Comment on attachment 8368902 [details] [diff] [review]
Install mozbase and from tests.zip,

Review of attachment 8368902 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm
Attachment #8368902 - Flags: review?(ahalberstadt) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Created attachment 8368902 [details] [diff] [review]
> Install mozbase and from tests.zip,

I noticed and fixed a problem with this on ash...we were explicitly install mozinstall from pypi, which resulted in an old version not compatible with current mozbase.  I removed this explicit install to let mozinstall get installed along with the rest of mozbase from tests.zip.

https://hg.mozilla.org/build/mozharness/rev/d219c3c32672
(In reply to Jonathan Griffin (:jgriffin) from comment #9)
> (In reply to Jonathan Griffin (:jgriffin) from comment #7)
> > Created attachment 8368902 [details] [diff] [review]
> > Install mozbase and from tests.zip,
> 
> I noticed and fixed a problem with this on ash...we were explicitly install
> mozinstall from pypi, which resulted in an old version not compatible with
> current mozbase.  I removed this explicit install to let mozinstall get
> installed along with the rest of mozbase from tests.zip.
> 
> https://hg.mozilla.org/build/mozharness/rev/d219c3c32672

Looks like this is in production, no problems.  I'm going to re-land the gaia PR that was originally backed out.
(In reply to Ryan VanderMeulen [:RyanVM UTC-5][Limited connectivity due to mass power outage] from comment #5)
> Reverted for TBPL failures.
> https://github.com/mozilla-b2g/gaia/commit/
> f9013a0d20824de7778ce60f824dc4d90b3cff1b
> 
> https://tbpl.mozilla.org/php/getParsedLog.php?id=33895119&tree=B2g-Inbound

Re-landed as https://github.com/mozilla-b2g/gaia/commit/94df28b68f47abdc8aaacdc4d05e12f3c959b13b
(In reply to Jonathan Griffin (:jgriffin) from comment #11)
> 
> Re-landed as
> https://github.com/mozilla-b2g/gaia/commit/94df28b68f47abdc8aaacdc4d05e12f3c959b13b

Looks like it stuck this time.
https://hg.mozilla.org/mozilla-central/rev/988fac0ec345
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
I should have marked this with leave-open; I still need to land a buildbot patch before this is totally operational.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Landed the last piece (hopefully) as https://hg.mozilla.org/build/mozharness/rev/537008cf308a
(In reply to Jonathan Griffin (:jgriffin) from comment #15)
> Landed the last piece (hopefully) as
> https://hg.mozilla.org/build/mozharness/rev/537008cf308a

Looks fine on cedar.
Mozharness change live in production.
All the pieces to this have landed.
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.