965937 - The Login and Save your project to share dialog makes people think they are not logged in

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

If your project cannot currently be shard, because it is in a dirty state, and you go into the project editor, you see a "Login and Save your project to share" dialog.

While this is true, you need to be logged in and to be saved before you can share, people interpret this message as instructions based on the current state. So, they think "oh, I am not logged in, but it says I am logged in".

This is pretty scary if you have a large project you're trying to save and don't want to lose anything.

Also, thimble has a save button in the project dialog, and people used to thimble click project to try to save.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/439

Comment 2

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/43e69b9564c5cdf416a8f9dc1c5c00d7f55219c8

Needs verification.