965952 - Remove useless GetVersionEx call from TestWinFileAttribs.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Masatoshi Kimura [:emk]]

We don't support WinXP SP1 or earlier anymore.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Remove GetVersionEx call from TestwinFileAttribs.cpp

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8368112 [details] [diff] [review]
Remove GetVersionEx call from TestwinFileAttribs.cpp

Review of attachment 8368112 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like we don't even run this test.  It's not in moz.build/Makefile.in, and I don't see any output from it in the test logs on TBPL.

Comment 3

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b68a429b695

Comment 4

[(no longer active)]

(In reply to comment #2)
> It looks like we don't even run this test.  It's not in moz.build/Makefile.in,
> and I don't see any output from it in the test logs on TBPL.

So why not just remove the test?!

Comment 5

[Jim Mathies [:jimm]]

(In reply to :Ehsan Akhgari (needinfo? me!) (@ work week, reduced responsiveness) from comment #4)
> (In reply to comment #2)
> > It looks like we don't even run this test.  It's not in moz.build/Makefile.in,
> > and I don't see any output from it in the test logs on TBPL.
> 
> So why not just remove the test?!

You can still run this locally provided you are using ntfs. We should be running on ntfs file systems in automation but we currently don't. Maybe someday we will, at which point this can be enabled.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5b68a429b695