Closed Bug 965998 Opened 10 years ago Closed 10 years ago

JSVAL_* symbols removed in Firefox 27 libxul.so

Categories

(Firefox :: Untriaged, defect)

Product:
Firefox
Component:
Untriaged
Version:
27 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 920731

People

(Reporter: skybrian, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.102 Safari/537.36

Steps to reproduce:

(Not sure this counts as a bug, but I'm documenting this in case anyone else runs into  it.)

I built a plugin against XulRunner 27 headers and libraries to deploy with Firefox 27, which uses the JSVAL* symbols.



Actual results:

A link error appears in the Browser console when the plugin loads:

Failed to load native module at path '/usr/local/google/home/skybrian/.mozilla/firefox/4f0n7icu.default/extensions/gwt-dev-plugin@google.com/lib/Linux_x86-gcc3/ff270/libgwt_dev_ff270.so': (80004005) /usr/local/google/home/skybrian/.mozilla/firefox/4f0n7icu.default/extensions/gwt-dev-plugin@google.com/lib/Linux_x86-gcc3/ff270/libgwt_dev_ff270.so: undefined symbol: JSVAL_VOID

It looks like libxul doesn't contain these symbols anymore:
objdump -T libxul.so | grep JSVAL

However they do appear in XulRunner 27:
$ objdump -T libxul.so | grep JSVAL

02064e88 g    DO .rodata	00000008  xul27       JSVAL_VOID
02064ea8 g    DO .rodata	00000008  xul27       JSVAL_ZERO
02064e98 g    DO .rodata	00000008  xul27       JSVAL_FALSE
02064ea0 g    DO .rodata	00000008  xul27       JSVAL_ONE
02064eb0 g    DO .rodata	00000008  xul27       JSVAL_NULL
02064e90 g    DO .rodata	00000008  xul27       JSVAL_TRUE



Expected results:

Assuming Firefox is dropping these symbols, I suggest removing them from the headers, to force compile-time errors.

The new way to do this appears to be using method on the JS::Value class defined in js/public/Value.h.
On further investigation, it looks like all symbols starting with JS_ are no longer in libxul.so.
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.