Closed Bug 966084 Opened 12 years ago Closed 12 years ago

don't QI the result of window->GetFrameElementInternal() when we don't need to

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla32

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file, 1 obsolete file)

bug 966084 - don't QI the result of win->GetFrameElementInternal() when its not required
14.40 KB, patch
smaug
: review+
Ms2ger
: feedback+
Details | Diff | Splinter Review
No description provided.
Comment on attachment 8368308 [details] [diff] [review] bug 966084 - don't QI the result of win->GetFrameElementInternal() when its not required Review of attachment 8368308 [details] [diff] [review]: ----------------------------------------------------------------- Would you mind looking if any of those could become nsCOMPtr<Element> instead? In particular, I'd like to move the attribute-related functions to Element at some point, and that would save me some work :)
Attachment #8368308 - Flags: review?(bugs)
Comment on attachment 8376426 [details] [diff] [review] bug 966084 - don't QI the result of win->GetFrameElementInternal() when its not required Review of attachment 8376426 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8376426 - Flags: review?(bugs)
Attachment #8376426 - Flags: review?(Ms2ger)
Attachment #8376426 - Flags: feedback+
Attachment #8376426 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/ca0fc67da7cb
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: