966102 - Child processes warn a lot on startup

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch

I currently get a bunch of warnings when a child starts up of the form:

[Child 26993] WARNING: '!mMainThread', file /Users/mrbkap/work/tree2/mozilla/xpcom/threads/nsThreadManager.cpp, line 265
[Child 26993] WARNING: 'NS_FAILED(rv)', file /Users/mrbkap/work/tree2/mozilla/xpcom/glue/nsThreadUtils.cpp, line 180

This appears to be because we attempt to send the crash reporter constructor before initializing XPCOM and we warn when the responses come in (still before we initialize XPCOM). The patch I'm attaching quiets the warnings.

Comment 1

[Benjamin Smedberg]

Comment on attachment 8368323 [details] [diff] [review]
patch

What is the stack of the warning? Something feels a little wrong about this, especially because nsThreadManager::Init is going to be called again from XPCOM init and doesn't have a specific failure check so it seems like we're going to leak the first mLock.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Addressing bsmedberg's review comments

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: stacks for posterity

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5cf89fb575c4

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5cf89fb575c4