Closed Bug 966102 Opened 6 years ago Closed 6 years ago

Child processes warn a lot on startup

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
I currently get a bunch of warnings when a child starts up of the form:

[Child 26993] WARNING: '!mMainThread', file /Users/mrbkap/work/tree2/mozilla/xpcom/threads/nsThreadManager.cpp, line 265
[Child 26993] WARNING: 'NS_FAILED(rv)', file /Users/mrbkap/work/tree2/mozilla/xpcom/glue/nsThreadUtils.cpp, line 180

This appears to be because we attempt to send the crash reporter constructor before initializing XPCOM and we warn when the responses come in (still before we initialize XPCOM). The patch I'm attaching quiets the warnings.
Attachment #8368323 - Flags: review?(benjamin)
Comment on attachment 8368323 [details] [diff] [review]
patch

What is the stack of the warning? Something feels a little wrong about this, especially because nsThreadManager::Init is going to be called again from XPCOM init and doesn't have a specific failure check so it seems like we're going to leak the first mLock.
Attachment #8368323 - Flags: review?(benjamin) → review-
Attachment #8368323 - Attachment is obsolete: true
Attachment #8368695 - Flags: review?(benjamin)
Attachment #8368695 - Flags: review?(benjamin) → review+
https://hg.mozilla.org/mozilla-central/rev/5cf89fb575c4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.