Closed
Bug 966102
Opened 11 years ago
Closed 11 years ago
Child processes warn a lot on startup
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(2 files, 1 obsolete file)
|
3.60 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
6.19 KB,
text/plain
|
Details |
I currently get a bunch of warnings when a child starts up of the form:
[Child 26993] WARNING: '!mMainThread', file /Users/mrbkap/work/tree2/mozilla/xpcom/threads/nsThreadManager.cpp, line 265
[Child 26993] WARNING: 'NS_FAILED(rv)', file /Users/mrbkap/work/tree2/mozilla/xpcom/glue/nsThreadUtils.cpp, line 180
This appears to be because we attempt to send the crash reporter constructor before initializing XPCOM and we warn when the responses come in (still before we initialize XPCOM). The patch I'm attaching quiets the warnings.
Attachment #8368323 -
Flags: review?(benjamin)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8368323 [details] [diff] [review]
patch
What is the stack of the warning? Something feels a little wrong about this, especially because nsThreadManager::Init is going to be called again from XPCOM init and doesn't have a specific failure check so it seems like we're going to leak the first mLock.
Attachment #8368323 -
Flags: review?(benjamin) → review-
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8368323 -
Attachment is obsolete: true
Attachment #8368695 -
Flags: review?(benjamin)
|
|
||
Updated•11 years ago
|
Attachment #8368695 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•11 years ago
|
||
Keywords: checkin-needed
|
||
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•