Closed Bug 966167 Opened 6 years ago Closed 6 years ago

Rename tipSection.tip0 in browser.properties to reflect string change

Categories

(Firefox :: Toolbars and Customization, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: flod, Assigned: mikedeboer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:P1])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #870593 +++

As usual, once landed on mozilla-central, you can't change landed strings without providing a new ID
http://hg.mozilla.org/mozilla-central/rev/5c60f72dad0c

Please fix this before it moves to Aurora next Tuesday.
Summary: Rename tipSection.tip0 to reflect string change → Rename tipSection.tip0 in browser.properties to reflect string change
Francesco, this was a follow-up to a fix an error in the initial commit a few hours earlier. If it weren't for the tree closure of both fx-team and m-c, these two commits would've been minutes apart.

I understand that looking at this commit without this context, it seems like a violation of the rules, of which I'm fully aware, but this an exception.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
I completely disagree, but I don't plan on starting a battle of close and reopen.

There are already 5 translation of this string, and 4 of them are broken (not wrong, broken, considering that one variable has a completely different value). The only one correct is mine, because I noticed the error this morning and filed the bug.
http://transvision.mozfr.org/string/?entity=browser/chrome/browser/browser.properties:tipSection.tip0&repo=central

Alternative to rename the string is to file individual bugs to be sure these localizers notice it. But that's not something we should do every time a problem like this happens.
Ahaaa, in that case I'll change the string ID! Awesome localizers are awesome.
Assignee: nobody → mdeboer
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Comment on attachment 8368470 [details] [diff] [review]
Patch v1: update locale string IDs for the tip section

Review of attachment 8368470 [details] [diff] [review]:
-----------------------------------------------------------------

This'll be amusing if we ever screw up another one of these tips ;)
Attachment #8368470 - Flags: review?(bmcbride) → review+
(In reply to Blair McBride [:Unfocused] from comment #5)
> This'll be amusing if we ever screw up another one of these tips ;)

Tipception?

Francesco, thanks for taking the time to explain why this was absolutely necessary.

remote: https://hg.mozilla.org/integration/fx-team/rev/2cbf83798e15
No longer depends on: 870593
Whiteboard: [Australis:P1][fixed-in-fx-team]
Thanks Mike, I ensure you this is much appreciated :-)
https://hg.mozilla.org/mozilla-central/rev/2cbf83798e15
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][fixed-in-fx-team] → [Australis:P1]
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.