966167 - Rename tipSection.tip0 in browser.properties to reflect string change

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Francesco Lodolo [:flod]]

+++ This bug was initially created as a clone of Bug #870593 +++

As usual, once landed on mozilla-central, you can't change landed strings without providing a new ID
http://hg.mozilla.org/mozilla-central/rev/5c60f72dad0c

Please fix this before it moves to Aurora next Tuesday.

Comment 1

[Mike de Boer [:mikedeboer]]

Francesco, this was a follow-up to a fix an error in the initial commit a few hours earlier. If it weren't for the tree closure of both fx-team and m-c, these two commits would've been minutes apart.

I understand that looking at this commit without this context, it seems like a violation of the rules, of which I'm fully aware, but this an exception.

Comment 2

[Francesco Lodolo [:flod]]

I completely disagree, but I don't plan on starting a battle of close and reopen.

There are already 5 translation of this string, and 4 of them are broken (not wrong, broken, considering that one variable has a completely different value). The only one correct is mine, because I noticed the error this morning and filed the bug.
http://transvision.mozfr.org/string/?entity=browser/chrome/browser/browser.properties:tipSection.tip0&repo=central

Alternative to rename the string is to file individual bugs to be sure these localizers notice it. But that's not something we should do every time a problem like this happens.

Comment 3

[Mike de Boer [:mikedeboer]]

Ahaaa, in that case I'll change the string ID! Awesome localizers are awesome.

Comment 4

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: update locale string IDs for the tip section

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8368470 [details] [diff] [review]
Patch v1: update locale string IDs for the tip section

Review of attachment 8368470 [details] [diff] [review]:
-----------------------------------------------------------------

This'll be amusing if we ever screw up another one of these tips ;)

Comment 6

[Mike de Boer [:mikedeboer]]

(In reply to Blair McBride [:Unfocused] from comment #5)
> This'll be amusing if we ever screw up another one of these tips ;)

Tipception?

Francesco, thanks for taking the time to explain why this was absolutely necessary.

remote: https://hg.mozilla.org/integration/fx-team/rev/2cbf83798e15

Comment 7

[Francesco Lodolo [:flod]]

Thanks Mike, I ensure you this is much appreciated :-)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2cbf83798e15