Closed Bug 966197 Opened 6 years ago Closed 6 years ago

Make sure all suffixes in PSL are lower-case, and update test to check this

Categories

(Core :: Networking: Domain Lists, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: gerv, Assigned: weppos)

Details

Attachments

(2 files)

We should make all the suffixes in the PSL lower-case. And we should update the PSL test (or add a new test) to make sure this is the case, so we don't regress. 

Gerv
weppos: are you able to take this on?

Gerv
+1. I also vote to update the site to mention this information.
weppos: so can you prepare a patch? :-)

Gerv
The ICANN New TLDs are all coming in lower now but previous were mixed case.

Might be worth doing the whole new TLD section over which is the primary culprit of mixed case.

I've attached the entire new TLD contracted list through 2/5, lc'd as a text file attachment.
Attached patch CASE.patchSplinter Review
Here's the patch for TOKYO. Apparently, this was the only leftover.

Still need to add the tests, but I need some time to investigate how to create and run them locally. In the meanwhile, I suggest to checkin this commit.
Attachment #8371844 - Flags: review?(gerv)
Comment on attachment 8371844 [details] [diff] [review]
CASE.patch

r=gerv.

Gerv
Attachment #8371844 - Flags: review?(gerv) → review+
https://hg.mozilla.org/mozilla-central/rev/e85f83f352de
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.