966197 - Make sure all suffixes in PSL are lower-case, and update test to check this

Status: RESOLVED FIXED

(Core Graveyard :: Networking: Domain Lists, defect)

Description

[Gervase Markham [:gerv]]

We should make all the suffixes in the PSL lower-case. And we should update the PSL test (or add a new test) to make sure this is the case, so we don't regress. 

Gerv

Comment 1

[Gervase Markham [:gerv]]

weppos: are you able to take this on?

Gerv

Comment 2

[Simone Carletti]

+1. I also vote to update the site to mention this information.

Comment 3

[Gervase Markham [:gerv]]

weppos: so can you prepare a patch? :-)

Gerv

Comment 4

[Jothan Frakes]

Attachment: txt file of all contracted ICANN new TLD strings from 7/14/13-2/5/2014, with the strings converted to lower case.

The ICANN New TLDs are all coming in lower now but previous were mixed case.

Might be worth doing the whole new TLD section over which is the primary culprit of mixed case.

I've attached the entire new TLD contracted list through 2/5, lc'd as a text file attachment.

Comment 5

[Simone Carletti]

Attachment: CASE.patch

Here's the patch for TOKYO. Apparently, this was the only leftover.

Still need to add the tests, but I need some time to investigate how to create and run them locally. In the meanwhile, I suggest to checkin this commit.

Comment 6

[Gervase Markham [:gerv]]

Comment on attachment 8371844 [details] [diff] [review]
CASE.patch

r=gerv.

Gerv

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e85f83f352de

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e85f83f352de