Closed Bug 966199 Opened 6 years ago Closed 6 years ago

There's a bit of redundancy and inconsistency in the breadcrumbs styles

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file)

Some non-themable properties are defined twice both for dark and light themes, and some colors are set twice, redundantly. This is nothing user-facing, but makes the css rules look a bit dirty.
I also grouped theme colors rules together, to make it easier to spot bugs.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8368465 - Flags: review?(bgrinstead)
Comment on attachment 8368465 [details] [diff] [review]
breadcrumbs-normalize.patch

Review of attachment 8368465 [details] [diff] [review]:
-----------------------------------------------------------------

This is a good refactor of the breadcrumbs CSS
Attachment #8368465 - Flags: review?(bgrinstead) → review+
https://hg.mozilla.org/mozilla-central/rev/671618886656
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.