966210 - When enabled, B2G devtools layers should instantly work for apps that are already running.

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Jan Keromnes [:janx]]

Observed: When enabling "Settings > Developer > Show devtools overlay", an overlay is shown over apps when they are being started.

Expected: Not only should it work for apps that are later started, but also for apps that were already running when the setting was enabled.

To achieve this, the devtools layers should query the list of running apps and track them. This can be done by extracting the `listRunningApps` method of the webappsActor.

Comment 1

[Jan Keromnes [:janx]]

Attachment: Make B2G devtools layers track all running apps on init.

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8371311 [details] [diff] [review]
Make B2G devtools layers track all running apps on init.

Review of attachment 8371311 [details] [diff] [review]:
-----------------------------------------------------------------

Shouldn't we also track the system app?

Comment 3

[Jan Keromnes [:janx]]

Thanks for the review! We currently don't track the system app, because we first need to figure out a good place to display its metrics information. (The bottom right on the home screen is already used by the home screen, maybe inside the drop-down menu?)

Comment 4

[Jan Keromnes [:janx]]

Attachment: Make B2G devtools layers track all running apps on init.

Comment 5

[Jan Keromnes [:janx]]

Comment on attachment 8371384 [details] [diff] [review]
Make B2G devtools layers track all running apps on init.

Review of attachment 8371384 [details] [diff] [review]:
-----------------------------------------------------------------

Replaced stray `var` with a `let`, carrying over Alex's r+.

Comment 6

[Jan Keromnes [:janx]]

Attachment: Make B2G devtools layers track all running apps on init. r=ochameau

Comment 7

[Jan Keromnes [:janx]]

Comment on attachment 8371387 [details] [diff] [review]
Make B2G devtools layers track all running apps on init. r=ochameau

Appended "r=ochameau" to commit message.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/77e2ec465aca

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77e2ec465aca