966282 - Scrolling in the Firefox marketplace is significantly worse in Nightly (29) & Aurora (28) than GA (26)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Deb Richardson [:dria] (plz NEEDINFO)]

kats and mbrubeck suggested this might be a regression of bug 893236.  Either way, scrolling is close to unusably bad on Marketplace right now.

Comment 1

[Aaron Train [:aaronmt]]

Last good revision: 7e79536aca0a (2014-01-29)
First bad revision: 73eefb421e2a (2014-01-30)

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7e79536aca0a&tochange=73eefb421e2a

I'd like to say bug 961280.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I don't believe bug 961280 should affect anything on Fennec; the code isn't used there. Can we narrow the range further with inbound builds?

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

changeset:   165664:4f0d8916386e
user:        Botond Ballo <[e-mail]>
date:        Mon Jan 27 19:51:35 2014 -0500
summary:     Bug 962791 - Do not wrap a position:absolute item into a ScrollLayer item if its containing block if outside the scrolled frame. r=roc

Comment 4

[Botond Ballo [:botond]]

Attachment: Display list dump

Comment 5

[Botond Ballo [:botond]]

Attachment: Frame dump (not from same run)

Comment 6

[Jason Smith [:jsmith]]

Sarah - Can someone check to see if this happens on FxOS?

Comment 7

[Timothy Nikkel (:tnikkel)]

I would expect this problem to affect b2g as well in general (although possibly not for this one specific site).

Comment 8

[Matthew Vaughan]

Attachment: Choppy scrolling on 1.3

I am seeing an issue with scrolling, but it isn't throughout the Marketplace app. When scrolling up or down near or on the 'Featured Apps' area, the scrolling becomes pretty choppy. This occurred on a Buri and Helix on their respective 01/31/14 1.3 and Master(1.4) builds. I have attached a video of the issue occurring on a Buri with 1.3. The scrolling is quick to show the choppiness, but this will occur no matter what speed the user scrolls.

The scrolling became much smoother once I got a little away from the top of the screen, even after selecting 'More' at the bottom to load more apps to view. Scrolling remained pretty smooth when navigating to other areas of the Marketplace app.

- Buri 1.3 build -
Device: Buri v1.3 MOZ RIL
BuildID: 20140131004001
Gaia: 0ddcd8da5bfe1b48c73502ef29220e92f2db6b73
Gecko: 32e45047b663
Version: 28.0a2
Firmware Version: V1.2-device.cfg

Comment 9

[Botond Ballo [:botond]]

Attachment: Display list dump

Comment 10

[Botond Ballo [:botond]]

Attachment: Frame dump (with matching addresses this time)

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+                      nsLayoutUtils::IsProperAncestorFrame(mScrolledFrame, aItem->Frame(), nullptr);

I think IsProperAncestorFrame should be IsAncestorFrameCrossDoc. Does that help?

Comment 12

[Timothy Nikkel (:tnikkel)]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #11)
> +                      nsLayoutUtils::IsProperAncestorFrame(mScrolledFrame,
> aItem->Frame(), nullptr);
> 
> I think IsProperAncestorFrame should be IsAncestorFrameCrossDoc. Does that
> help?

The patch means we no longer wrap a fixed position item, and it is between two scroll layer items, causing us to fail to merge scroll layer items into one. I think it is correct that we are no longer wrapping this fixed position item.

Comment 13

[Botond Ballo [:botond]]

(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #11)
> +                      nsLayoutUtils::IsProperAncestorFrame(mScrolledFrame,
> aItem->Frame(), nullptr);
> 
> I think IsProperAncestorFrame should be IsAncestorFrameCrossDoc. Does that
> help?

I tried it - it does not help.

Comment 14

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I guess this bug is going to be fixed by backout of bug 962791. Let's talk over there.

Comment 15

[Jason Smith [:jsmith]]

Fixed via backout in bug 962791.