966343 - Add-on Options UI issues with radio, centering of title and description

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Add-on Manager, defect)

Description

[Adrian Aichner [:anaran]]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140130030202

Steps to reproduce:

I added some options to an add-on I am writing.

"preferences": [{
            "description": "Controls the amount of logging to the browser console by level, from most to nothing at all.",
    "name": "consoleLogLevel",
    "type": "radio",
    "title": "Console Logging Level",
    "value": "off",
    "options": [
        {
            "value": "all",
            "label": "all"
        },
        {
            "value": "debug",
            "label": "debug"
        },
        {
            "value": "info",
            "label": "info"
        },
        {
            "value": "warn",
            "label": "warn"
        },
        {
            "value": "error",
            "label": "error"
        },
        {
            "value": "off",
            "label": "off"
        }
    ]
}, {
        "name": "DATAFORMAT1",
            "type": "string",
            "description": "Name of first user-defined entry format, made available as snapper download format.\nThe data format is described by three format components: DATE FORMAT, INFORMATION FORMAT, and ENTRY FORMAT.",
            "value": "timeclock",
            "title": "1. User-Defined Entry Format"
    }, {
        "name": "DATEFORMAT",
            "type": "string",
            "description": "Set Snapper Date and Time Format (%Y = Year, %m = Month, %d = Day, %H = Hour, %M = Minute, %S = Second, %z = Timezone Offset).",
            "value": "%Y/%m/%d %H:%M:%S",
            "title": "1. DATE FORMAT"
    }, {
        "name": "INFOFORMAT",
            "type": "string",
            "description": "Set Snapper Information Format (%u = URL, %t = title, %s = selection).",
            "value": "Snap!\\\\n# %t\\\\n@ %u\\\\n%s",
            "title": "1.INFORMATION FORMAT"
    }, {
        "name": "ENTRYFORMAT",
            "type": "string",
            "description": "Set Snapper Entry Format (%i = start datetime, %o = end datetime, %t = snapper text).",
            "value": "%i %t\\\\no %o\\\\n",
            "title": "1. ENTRY FORMAT"
    }]


Actual results:

Radio buttons don't show, even thought clicking their labels works. This means that user will not know which radio button is currently active.

String option title and description are centered in landscape mode, looking real ugly in my opinion.

See pictures I will attach in a minute.


Expected results:

Radio buttons need to show active state to user.

String option title and description should align left in landscape mode (in ltr locales), just like they do in portrait.

Comment 1

[Adrian Aichner [:anaran]]

Attachment: Screenshot_2014-01-31-02-01-37[1].png

Radio buttons don't show, only labels

Comment 2

[Adrian Aichner [:anaran]]

Attachment: Screenshot_2014-01-31-02-02-03.png

Comment 3

[Adrian Aichner [:anaran]]

Attachment: Screenshot_2014-01-31-02-02-23.png

Comment 4

[Adrian Aichner [:anaran]]

Comment on attachment 8368661 [details]
Screenshot_2014-01-31-02-01-37[1].png

Centered title and description looks bad when mutiple are shown with varying text length.

Comment 5

[Adrian Aichner [:anaran]]

Comment on attachment 8368665 [details]
Screenshot_2014-01-31-02-02-03.png

Radio buttons don't show, only labels.

Comment 6

[Adrian Aichner [:anaran]]

Comment on attachment 8368667 [details]
Screenshot_2014-01-31-02-02-23.png

title and description of varying lengths look good in portrait mode because they align left.

Also, radio buttons don't show.

Comment 7

[Adrian Aichner [:anaran]]

Using "type": "menulist" instead of "radio" works well in nightly Fennec on Android 4.3.

The radio buttons make for a more explorable UI though.

Comment 8

[:Margaret Leibovic]

The UI has changed since bug 988068 was fixed. Are you still seeing this issue?

Bug 1079466 would definitely help fix this.

Comment 9

[Adrian Aichner [:anaran]]

Hi Margaret, I still see no radio buttons in nightly fennec, building cfx xpi with sdk version 1.17.

When I try to build with cfx from addon-sdk master HEAD I get not options displayed in fennec at all, although same xpi works fine in Windows XP.

Let me know what else I should try.

Comment 10

[Adrian Aichner [:anaran]]

The test case I am using is
https://github.com/anaran/JotFirefox

Comment 11

[:Margaret Leibovic]

Thanks for the quick response. I haven't tried using the add-on SDK preferences before. It would be useful if we could crate an options.xul testcase. We could add one here:
https://github.com/leibovic/options-kitchen-sink/blob/master/content/options.xul

I see here it looks like the add-on SDK creates a radiogroup element:
https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/preferences/native-options.js#L157

In bug 1079466, we're going to work to replace options.xul with a JS module for mobile, since we don't really support rendering XUL on mobile.

I'm afraid fixing this bug might involve fixing the way we render XUL radiogroups, which may not be worth pursuing. So unfortunately you may just need to wait for bug 1079466.

Comment 12

[Andy McKay]

With Firefox 57 only WebExtensions are supported and options are HTML pages.