966373 - Yahoo TV does not trigger any notification about Flash being disabled

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Kaply [:mkaply]]

I have plugin.state.flash set to 1.

When I go to:

http://tv.yahoo.com/primetime/lopez-emotional-over-idol-reunion-050205478.html

I get no notifications about flash (no notification bar, no doorhanger).

I should get some indication that I need to enable flash,

Comment 1

[Benjamin Smedberg]

Can you provide a screenshot? Note that if there is any visible Flash on the page, we won't show the infobar. For me, there is a Flash ad visible on the page.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Screenshot of problem

The problem is that you don't get the plugin box asking to enable the plugin.

So to a user, it just looks like the video didn't load (the circle keeps spinning).

If you click on the circle, you get the ask, but a user wouldn't necessarily know to do that.

Comment 3

[Mike Kaply [:mkaply]]

To be clear, I scrolled through the whole page and looked around and nowhere did I see the "click here to enable flash" box.

All I see is the spinning circle in the middle.

Comment 4

[Alice0775 White]

Attachment: WFM, I can see Notification Bar

http://hg.mozilla.org/mozilla-central/rev/5e0a22097bff
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 ID:20140131030203

Comment 5

[Mike Kaply [:mkaply]]

I just did a new profile, nightly on Windows and I do not get the notification bar.

Steps were:

New profile.
Change plugin.state.flash to 1.
Go to the Yahoo TV website.
Spinning circle, no notification bar, no other flash on page.

This was a 1/28 windows nightly.

Comment 6

[Mike Kaply [:mkaply]]

Sane result with 1/31...

Comment 7

[Georg Fritzsche [:gfritzsche]]

I do see in-page overlays, but for one load of the site only the lowermost right-side ad (outside of the current scroll view) was Flash and visible, so it's not obvious.
I wonder if we could just show the notification bar if there is at least one invisible CTP element, given that IMO ads are usually visible?

Comment 8

[Benjamin Smedberg]

We could, but I really don't want to. You could basically force the infobar to appear by hiding a plugin somewhere, and I don't want that.

Comment 9

[Benjamin Smedberg]

I am going to file a separate bug about scroll positioning messing up the hidden-plugin algorithm: we're comparing coordinates with different origins which might affect this especially on slower connections.

Comment 10

[Mike Kaply [:mkaply]]

So is the rule that if the plugin is not visible to the user (as in scrolled off screen) we show the info bar? Or if it is not on the web page at all?

Comment 11

[Benjamin Smedberg]

It should be if it is not visible on at all. I think there may be a bug especially WRT iframes.