nsIBidiKeyboard::SetLangFromBidiLevel should be removed

RESOLVED FIXED in mozilla29

Status

()

Core
Widget
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

unspecified
mozilla29
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
This function is only implemented on Windows, where it does some work and throws it away. The behavior implied would be very surprising (changing the system keyboard language based on if you click in RTL text or LTR text) if implemented anyway.

We should nuke it with prejudice.

Comment 1

4 years ago
Hey Simon, if you give me your blessings here, I would be happy to write the patch.
Flags: needinfo?(smontagu)
(Assignee)

Comment 2

4 years ago
Created attachment 8368740 [details] [diff] [review]
Patch

I'm purposely *not* cleaning anything else up here, though there is a ton of cleanup left to do.
Attachment #8368740 - Flags: review?(roc)
(Assignee)

Updated

4 years ago
Attachment #8368740 - Flags: review?(roc) → review?(smontagu)
(Assignee)

Updated

4 years ago
Assignee: nobody → mrbkap
Comment on attachment 8368740 [details] [diff] [review]
Patch

Review of attachment 8368740 [details] [diff] [review]:
-----------------------------------------------------------------

Given this is dead code, there's no reason to keep it around.
Attachment #8368740 - Flags: review?(smontagu) → review+
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cae03e1c434
Flags: needinfo?(smontagu)
https://hg.mozilla.org/mozilla-central/rev/4cae03e1c434
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.