Closed Bug 966398 Opened 6 years ago Closed 6 years ago

nsIBidiKeyboard::SetLangFromBidiLevel should be removed

Categories

(Core :: Widget, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

This function is only implemented on Windows, where it does some work and throws it away. The behavior implied would be very surprising (changing the system keyboard language based on if you click in RTL text or LTR text) if implemented anyway.

We should nuke it with prejudice.
Hey Simon, if you give me your blessings here, I would be happy to write the patch.
Flags: needinfo?(smontagu)
Attached patch PatchSplinter Review
I'm purposely *not* cleaning anything else up here, though there is a ton of cleanup left to do.
Attachment #8368740 - Flags: review?(roc)
Attachment #8368740 - Flags: review?(roc) → review?(smontagu)
Assignee: nobody → mrbkap
Comment on attachment 8368740 [details] [diff] [review]
Patch

Review of attachment 8368740 [details] [diff] [review]:
-----------------------------------------------------------------

Given this is dead code, there's no reason to keep it around.
Attachment #8368740 - Flags: review?(smontagu) → review+
https://hg.mozilla.org/mozilla-central/rev/4cae03e1c434
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.