Closed
Bug 966398
Opened 12 years ago
Closed 12 years ago
nsIBidiKeyboard::SetLangFromBidiLevel should be removed
Categories
(Core :: Widget, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: mrbkap, Assigned: mrbkap)
Details
Attachments
(1 file)
|
6.61 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This function is only implemented on Windows, where it does some work and throws it away. The behavior implied would be very surprising (changing the system keyboard language based on if you click in RTL text or LTR text) if implemented anyway.
We should nuke it with prejudice.
|
||
Comment 1•12 years ago
|
||
Hey Simon, if you give me your blessings here, I would be happy to write the patch.
Flags: needinfo?(smontagu)
|
Assignee | |
Comment 2•12 years ago
|
||
I'm purposely *not* cleaning anything else up here, though there is a ton of cleanup left to do.
Attachment #8368740 -
Flags: review?(roc)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8368740 -
Flags: review?(roc) → review?(smontagu)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mrbkap
Comment on attachment 8368740 [details] [diff] [review]
Patch
Review of attachment 8368740 [details] [diff] [review]:
-----------------------------------------------------------------
Given this is dead code, there's no reason to keep it around.
Attachment #8368740 -
Flags: review?(smontagu) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Flags: needinfo?(smontagu)
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•