966457 - Consolidate all dashboard/metric metadata in a single file

Status: RESOLVED FIXED

(Testing Graveyard :: Eideticker, defect, P3)

Description

[William Lachance (:wlach)]

Right now test metadata (frame differences, http requests, etc.) for metrics is dispersed in a bunch of metadata files. As we add more types of metadata, this is getting unwieldly to track and sync. Let's consolidate all of it (except for the bare numbers needed to generate graphs) in a single json file per testrun. Incidentally, this should probably make the datazilla migration we're hoping to do this quarter easier (since iirc datazilla supports holding arbitrary json blobs).

Comment 1

[William Lachance (:wlach)]

Attachment: Refactor metadata collection / display

This rather large patch does what the bug asks for. Note that you need to run a conversion script on the dashboard data for it to work.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8375856 [details] [diff] [review]
Refactor metadata collection / display

Review of attachment 8375856 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me, though I haven't tested it locally due to a lack of data/hardware. What do we need to do to convert any existing data, such as the dashboards generated by the CI?

::: src/dashboard/framediff-view.html
@@ +null,0 @@


Is this an intentional change?

Comment 3

[William Lachance (:wlach)]

(In reply to Dave Hunt (:davehunt) from comment #2)
> Comment on attachment 8375856 [details] [diff] [review]
> Refactor metadata collection / display
> 
> Review of attachment 8375856 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks good to me, though I haven't tested it locally due to a lack of
> data/hardware. What do we need to do to convert any existing data, such as
> the dashboards generated by the CI?
> 
> ::: src/dashboard/framediff-view.html
> @@ +null,0 @@
> 
> 
> Is this an intentional change?

Yup, just wanted to use a simpler name for consistency with the new http log view.

Comment 4

[William Lachance (:wlach)]

Ok, this is pushed:

https://github.com/mozilla/eideticker/commit/47ebfb7273d1e07b26f18cde7b104b4d991a0b82

I also converted the existing b2g dashboard to use the new schema, so we should see that tomorrow when we run stuff again. Lookin' good locally.

I'll convert the Android stuff later this week...

Comment 5

[William Lachance (:wlach)]

Android dashboard converted.