Closed
Bug 966502
Opened 12 years ago
Closed 12 years ago
Use Cu.cloneInto() instead of ObjectWrapper.jsm
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 C3/1.4 S3(31jan)
People
(Reporter: fabrice, Assigned: fabrice)
References
Details
Attachments
(1 file)
|
26.58 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
The only remaining users of the jsm are the settings api files that use getObjectKind.
Baku, I never used the cloneFunctions flag - I don't think we ever supported or used that with the js version.
Attachment #8368872 -
Flags: review?(amarchesini)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8368872 [details] [diff] [review]
remove-object-wrapper.patch
Review of attachment 8368872 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good.
Attachment #8368872 -
Flags: review?(amarchesini) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C3/1.4 S3(31jan)
|
||
Comment 5•12 years ago
|
||
Comment on attachment 8368872 [details] [diff] [review]
remove-object-wrapper.patch
Review of attachment 8368872 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/nfc/nsNfc.js
@@ +276,5 @@
> let peerEvent = (NFC_PEER_EVENT_READY === evt) ? "peerready" : "peerlost";
> let detail = {
> "detail":sessionToken
> };
> + let event = new this._window.CustomEvent(peerEvent, this._wrap(detail);
Missed ')' at the end of line here and causes bug 968063.
You need to log in
before you can comment on or make changes to this bug.
Description
•