966626 - CommandExecuteHandler.exe - Application Error

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect)

Description

[Gary [:streetwolf52]]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140131171045

Steps to reproduce:

Open up Fx29 by clicking on an external link from another program.


Actual results:

Event Log:

Faulting application name: CommandExecuteHandler.exe, version: 29.0.0.5142, time stamp: 0x52eab06b
Faulting module name: SHELL32.dll, version: 6.3.9600.16474, time stamp: 0x52902a5b
Exception code: 0xc0000005
Fault offset: 0x001c6322
Faulting process id: 0x10d8
Faulting application start time: 0x01cf1ed7b44a29e6
Faulting application path: C:\Users\Gary\My Programs\firefox\CommandExecuteHandler.exe
Faulting module path: C:\Windows\SYSTEM32\SHELL32.dll
Report Id: f28bde87-8aca-11e3-83f3-c86000a0a026
Faulting package full name: 
Faulting package-relative application ID:



Expected results:

No error when Fx29 is opened via an external link.

Comment 1

[Gary [:streetwolf52]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/c0ee7e389205  - Good
http://hg.mozilla.org/integration/mozilla-inbound/rev/a41fdfce8810  - Bad

Even though I get this error and the one that Nightly needs to be closed replying yes keeps me in Nightly with no Nightly crash.

Comment 2

[Jim Mathies [:jimm]]

A few question - 

1) do you have the inbound build set as the default system browser?
2) if it's the default, which front end do you have selected? (desktop/metro)
3) Do you have other revs of firefox installed on the system?

Would you mind posting the log of the ceh doing its thing on this system?

https://wiki.mozilla.org/Firefox/Windows_8_Integration#Diagnosing_Command_Execute_Handler_Issues

Comment 3

[Gary [:streetwolf52]]

(In reply to Jim Mathies [:jimm] from comment #2)
> A few question - 
> 
> 1) do you have the inbound build set as the default system browser?
> 2) if it's the default, which front end do you have selected? (desktop/metro)
> 3) Do you have other revs of firefox installed on the system?
> 
> Would you mind posting the log of the ceh doing its thing on this system?
> 
> https://wiki.mozilla.org/Firefox/
> Windows_8_Integration#Diagnosing_Command_Execute_Handler_Issues

1. I use inbound as my default browser.
2. Front end is desktop
3. No other revs on my system.

Would you mind posting the log of the ceh doing its thing on this system?  What and where is this?  Remember that Fx doesn't actually crash AFAICT.

Comment 4

[Gary [:streetwolf52]]

Here's the log:

[1976] SHIMVIEW: ShimInfo(Complete) 
[4076] SetSelection target: http://www.santanderbank.com/
[4076] 
[4076] Initialize(open)
[4076] 
[4076] IExecuteCommandApplicationHostEnvironment::GetValue()
[4076] 
[4076] Previous AHE: 0
[4076] 
[4076] Execute()
[4076] 
[4076] Previous AHE: 0
[4076] 
[4076] Desktop Launch: verb:'open' exe:'C:\Users\Gary\My Programs\firefox\firefox.exe' params:'-url "http://www.santanderbank.com/"'
[4076] 
[4076] Desktop browser process id: 3820
[4076]

Comment 5

[Jim Mathies [:jimm]]

(In reply to Gary [:streetwolf] from comment #4)
> Here's the log:
> 
> [1976] SHIMVIEW: ShimInfo(Complete) 
> [4076] SetSelection target: http://www.santanderbank.com/
> [4076] 
> [4076] Initialize(open)
> [4076] 
> [4076] IExecuteCommandApplicationHostEnvironment::GetValue()
> [4076] 
> [4076] Previous AHE: 0
> [4076] 
> [4076] Execute()
> [4076] 
> [4076] Previous AHE: 0
> [4076] 
> [4076] Desktop Launch: verb:'open' exe:'C:\Users\Gary\My
> Programs\firefox\firefox.exe' params:'-url "http://www.santanderbank.com/"'
> [4076] 
> [4076] Desktop browser process id: 3820
> [4076]

After which you get a dialog about the crash?

Comment 6

[Jim Mathies [:jimm]]

Ok, I've managed to reproduce the event in the event viewer.

Comment 7

[Gary [:streetwolf52]]

Attachment: I get two error messages.

Comment 8

[Gary [:streetwolf52]]

Attachment: Capture1.PNG

Comment 9

[Gary [:streetwolf52]]

Pressing OK for the first error message, then close for the second one doesn't end Fx.  It continues as if nothing happened.

Comment 10

[Jim Mathies [:jimm]]

Attachment: fix: release the shell item array before the ceh releases

Quicker shutdown of the ceh seems to have triggered this. When the dtor of CExecuteCommandVerb gets call, the shell item array has already been destroyed and the Release call exception faults. Releasing before the ceh ref count drops to zero solves the issue.

Comment 11

[Jim Mathies [:jimm]]

Thanks for the quick turn around.

Note, I've cancelled the pending 02-01 Windows Nightly so our nightly users don't run into this. I'll land this fix directly on mc.

Comment 12

[Jim Mathies [:jimm]]

https://hg.mozilla.org/mozilla-central/rev/d09f9a9f81ae

Comment 13

[Jim Mathies [:jimm]]

BTW - thanks for testing Gary!

Comment 14

[Gary [:streetwolf52]]

(In reply to Jim Mathies [:jimm] from comment #13)
> BTW - thanks for testing Gary!

My pleasure.

Comment 15

[Jim Mathies [:jimm]]

Not seeing any problems with the newest mc nightly I triggered on this push.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b394be67993c

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/b394be67993c

Comment 18

[Manuela Muntean [Away]]

I couldn't reproduce this issue with the Nightly from 2014-01-31 on Win 8.1 64-bit: after setting Nightly as the default browser and opening a link from Skype, I don't get the error you mention.

Any thoughts/suggestions?

Comment 19

[Gary [:streetwolf52]]

Problem has been fixed.

Comment 20

[Manuela Muntean [Away]]

I've also tried to reproduce this issue with the Nightly from 2014-02-01, but still without any success.

Gary, could you please check this has been fixed with:

1) latest Beta (28 beta 2): ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/28.0b2-candidates
2) latest Aurora: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-aurora/
3) latest Nightly: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/

Comment 21

[Gary [:streetwolf52]]

The Nightly from 2014-02-01 shouldn't have the error since it first appeared on inbound on that day and the fix landed on m-c right away.  So the original bad patch wasn't on Nightly on that day which is why you can't reproduce it.

I suspect Beta and Aurora either don't have the original bad patch or have the fixed one.  In either case you won't get the error.

Comment 22

[Manuela Muntean [Away]]

Marking this verified fixed, based on comment 19 and comment 21 and on the fact that I wasn't able to reproduce this issue with neither the Nightly from 2014-01-31 nor the Nightly from 2014-02-01, as mentioned in comment 18 and comment 20.

Thanks Gary for your help.