966632 - Nightly punishes people for using it

Status: RESOLVED DUPLICATE of bug 966307

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Dreaded banner of doom

For the last couple of days I've been seeing this banner that says "Thanks for using nightly!" at the bottom of the screen. This happens on about:home and content as well. There's an X on the right that you can click to dismiss it but it keeps coming back. Clicking on the text part of it opens a tab to nightly.m.o - which is kind of silly given I'm already running nightly and the banner claims to know it. But wait, that's not all.

On the Galaxy Q at least and probably on other gingerbread devices, dismissing it has the same effect as hiding the dynamic toolbar (bug 956075) in that the area shows the content underneath, but trying to interact with it will still interact with the banner. This means any time I do a tap near the bottom of the screen, I open a new tab to nightly.m.o which interferes with my browsing. It's even worse because I can't just hit back to quickly close the tab - that ends up taking me to the homescreen. So I have to close the tab myself from the tab tray.

But wait, that's not all. I first saw the banner while I was in landscape. The Galaxy Q in landscape is pretty short so with the toolbar+banner space unavailable for interaction I had almost no usable space to pan pages and click on links. So I rotated to portrait to try and get some more height. But the banner didn't reposition properly and now it's just in the middle of the screen! (Screenshot attached).

What is this banner and why is it punishing me for using Nightly when it claims to do the opposite?

Comment 1

[Aaron Train [:aaronmt]]

This is partially bug 966307 which I filed.

Comment 2

[:Margaret Leibovic]

It sounds like most of this is bug 966307, which will be fixed tomorrow with a backout.

I'm sorry that we landed a bug in Nightly and took a few days to fix it, but hey, it's Nightly.

This banner is supposed to only show up as part of about:home, and the "Thanks for using Nightly" message was a test of the snippets service. It's just an unfortunately accident that we were testing that while bug 966307 happened.

Is there anything else actionable to do here, or can we just mark this as a dupe of bug 966307?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I'm fine with duping it if the banner is removed entirely, since that will take care of all the issues I described. If you bring back the banner though it would be nice if it didn't steal clicks even when hidden.