966639 - The search output panel should use theme colors

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: widget-colors.patch

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: Screenshot 2014-02-01 10.03.48.png

Should I be seeing different colors here for the hovered search result?  That's what I was assuming this was addressing, but it must be something else.

Comment 3

[Victor Porof [:vporof][:vp]]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> Created attachment 8369091 [details]
> Screenshot 2014-02-01 10.03.48.png
> 
> Should I be seeing different colors here for the hovered search result? 
> That's what I was assuming this was addressing, but it must be something
> else.

Not there :) Type @ in the searchbox to search for functions, or search for a file.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8369081 [details] [diff] [review]
widget-colors.patch

Review of attachment 8369081 [details] [diff] [review]:
-----------------------------------------------------------------

This is an improvement for sure. We should also consider doing something about the hover background colors for unselected elements in both themes (it is barely visible).  We could pick a different color from the list, or maybe do something just to add a bit of contrast on hover, like:

.theme-dark .simple-list-widget-item:not(.selected):hover {
  background-color: rgba(255, 255, 255, .1);
}

.theme-light .simple-list-widget-item:not(.selected):hover {
  background-color: rgba(0, 0, 0, .1);
}

Comment 5

[Victor Porof [:vporof][:vp]]

The hover colors were already picked from the wiki, but it guess they're pretty light. I did as you suggested and it looks better!

Comment 6

[Victor Porof [:vporof][:vp]]

(although i'm going to use a very slightly lower alpha)

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: widget-colors.patch

Addressed comments. Had to overwrite the colors in debugger.inc.css to prevent the global search look bad, but the file/function output panel uses the rgba() suggested approach.

Comment 8

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/16dfbbf8a159

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/16dfbbf8a159