checksetup should require admin e-mail address satisfy emailregexp.

RESOLVED FIXED in Bugzilla 2.16

Status

()

Bugzilla
Installation & Upgrading
P1
blocker
RESOLVED FIXED
17 years ago
5 years ago

People

(Reporter: CodeMachine, Assigned: zach)

Tracking

2.13
Bugzilla 2.16

Details

Attachments

(2 attachments)

(Reporter)

Description

17 years ago
When checksetup.pl initialises an installation, it asks for the admin address. 
I use a local user, since I don't have sendmail set up to do remote mailing.

Then it doesn't let that user log in because the address doesn't match
emailregexp.  I think that part might not be new.  I don't have a problem with
that behaviour - it shouldn't create the account in the first place.

Instead, if the admin account doesn't satisfy the default emailregexp, we should
 write out a more lax emailregexp and emailregexpdesc.  Optionally, we could
confirm this action out front.
(Reporter)

Updated

17 years ago
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.16
(Reporter)

Updated

17 years ago
Component: Bugzilla → Administration
Product: Webtools → Bugzilla
Version: Bugzilla 2.13 → 2.13
(Reporter)

Comment 1

17 years ago
Oops wrong component.  Reassigning too.
Assignee: justdave → zach
Component: Administration → Installation
This is going to be a blocker for the 2.16 release
Severity: normal → blocker
Priority: P2 → P1
(Assignee)

Comment 3

16 years ago
Created attachment 55418 [details] [diff] [review]
Patch to fix
Comment on attachment 55418 [details] [diff] [review]
Patch to fix

Looks good to me.  I'd give it first-review except that it has a MacBinary header on it so I can't apply it...
Attachment #55418 - Attachment mime type: text/plain → application/x-macbinary
Attachment #55418 - Flags: review-
Created attachment 55419 [details] [diff] [review]
the above patch without the MacBinary header
(Assignee)

Comment 6

16 years ago
Comment on attachment 55419 [details] [diff] [review]
the above patch without the MacBinary header

has dave's 1st review
Attachment #55419 - Flags: review+
Comment on attachment 55419 [details] [diff] [review]
the above patch without the MacBinary header

>
>+      unless ($login =~ /$mailcheckexp/) {
>+        print "\nThe login address must match the following pattern to be valid:\n";
>+        print "$mailcheck\n";
>+        die "Please try again\n";

Is the first line correct? You're not printing the pattern, you're printing a description
of a pattern. What about "The administrator's address is invalid.\n$mailcheck"? That matches
CheckEmailSyntax's text from CGI.pl

r=bbaetz in any case.
Attachment #55419 - Flags: review+
(Assignee)

Comment 8

16 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 9

16 years ago
I believe there is a problem with this patch, as it uses $::params rather than
$::param.

Comment 10

16 years ago
Ive raised the above problem as bug 133210.
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.