Remove DumpHeap call in ReleaseXPConnectSingleton

RESOLVED FIXED in mozilla30

Status

()

Core
XPConnect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla30
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I can't imagine anybody has used this in years.
Maybe dbaron, or someone he knows?
(Assignee)

Comment 2

4 years ago
Well, it looks like bz was using this feature back in 2007 (bug 378255).  Nowadays, DumpHeapComplete is a better way to deal with this, and you can dump the heap with the shutdown CC.  But I could see a use case for just getting a single JS heap log somewhere.

Boris, do you use XPC_SHUTDOWN_HEAP_DUMP any more?  I can change the implementation of it if anybody would find it useful.
Flags: needinfo?(bzbarsky)
(Assignee)

Updated

4 years ago
Flags: needinfo?(bzbarsky)
(Assignee)

Comment 3

4 years ago
Created attachment 8369497 [details] [diff] [review]
Remove DumpHeap call in ReleaseXPConnectSingleton.

In IRC, bz said he didn't think offhand that he used this environment variable any more.

If anybody wants some other way of loggin the heap at shutdown, let me know.

https://tbpl.mozilla.org/?tree=Try&rev=c1238ed7dd0a
Attachment #8369497 - Flags: review?(bobbyholley)
Attachment #8369497 - Flags: review?(bobbyholley) → review+
Sorry again, you'll find that failure incomprehensible from any of your patches because it was from bustage that landed on your bustage busted on the same builds.
https://hg.mozilla.org/mozilla-central/rev/f3445bd05ef8
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.