966766 - Smart pointerize XPCWrappedJSClass::GetNewOrUsed

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: part 1 - Remove null check in XPCWrappedJSClass::GetNewOrUsed. r=gabor

green L64 debug try run: https://tbpl.mozilla.org/?tree=Try&rev=c1238ed7dd0a

No particular hurry on these reviews, though there's nothing too fancy going on.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: part 2 - Move AddRef out of the ctor for XPCWrappedJSClass.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: part 3 - Rename clazz to clasp in XPCWrappedJSClass::GetNewOrUsed.

Comment 4

[Andrew McCreight [:mccr8]]

Attachment: part 4 - Smart pointerize clasp in XPCWrappedJSClass::GetNewOrUsed.

Comment 5

[Andrew McCreight [:mccr8]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f114c97660c6
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d1db5d2a417f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e2585386f84e
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e01c94498760

Comment 6

[Phil Ringnalda (:philor)]

Sorry, backed 'em all out in https://hg.mozilla.org/integration/mozilla-inbound/rev/930f794bfba3 for the https://tbpl.mozilla.org/php/getParsedLog.php?id=34108227&tree=Mozilla-Inbound bustage on the followup.

Comment 7

[Phil Ringnalda (:philor)]

Sorry again, you'll find that failure incomprehensible from any of your patches because it was from bustage that landed on your bustage busted on the same builds.

Comment 8

[Phil Ringnalda (:philor)]

Relanded in

https://hg.mozilla.org/integration/mozilla-inbound/rev/09b03d8d5477
https://hg.mozilla.org/integration/mozilla-inbound/rev/46e97b7c2c79
https://hg.mozilla.org/integration/mozilla-inbound/rev/879c18630cd3
https://hg.mozilla.org/integration/mozilla-inbound/rev/00ebfda3e2e5

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/09b03d8d5477
https://hg.mozilla.org/mozilla-central/rev/46e97b7c2c79
https://hg.mozilla.org/mozilla-central/rev/879c18630cd3
https://hg.mozilla.org/mozilla-central/rev/00ebfda3e2e5

Comment 10

[Andrew McCreight [:mccr8]]

Thanks for relanding my three bugs, philor!