Closed Bug 966800 Opened 6 years ago Closed 6 years ago

don't ignore blocking changes because another stream is finishing or underrunning

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
RecomputeBlockingAt is called iteratively until it returns with ?*aEnd >= aEndBlockingDecisions.
If one stream needs to block before aEndBlockingDecisions but after aTime, then the stream is not yet blocked but *aEnd is set to the time it needs to block (if *aEnd is not already <= this) so that it can be blocked in a future iteration.
Setting *aEnd to aEndBlockingDecisions, when considering another stream, defeats this.

This code was introduced in attachment http://hg.mozilla.org/mozilla-central/rev/74e761adfc42

I don't know what would be affected by not being blocked on time, but this is easy to fix.
Attachment #8369246 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/f36a681eb37a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
correcting target milestone, sorry for the bugmail spam
Target Milestone: mozilla30 → mozilla29
You need to log in before you can comment on or make changes to this bug.