Closed
Bug 966800
Opened 10 years ago
Closed 10 years ago
don't ignore blocking changes because another stream is finishing or underrunning
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
|
1.85 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
RecomputeBlockingAt is called iteratively until it returns with ?*aEnd >= aEndBlockingDecisions. If one stream needs to block before aEndBlockingDecisions but after aTime, then the stream is not yet blocked but *aEnd is set to the time it needs to block (if *aEnd is not already <= this) so that it can be blocked in a future iteration. Setting *aEnd to aEndBlockingDecisions, when considering another stream, defeats this. This code was introduced in attachment http://hg.mozilla.org/mozilla-central/rev/74e761adfc42 I don't know what would be affected by not being blocked on time, but this is easy to fix.
Attachment #8369246 -
Flags: review?(roc)
Attachment #8369246 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f36a681eb37a
Flags: in-testsuite-
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f36a681eb37a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
|
|
||
Comment 4•10 years ago
|
||
correcting target milestone, sorry for the bugmail spam
Target Milestone: mozilla30 → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•