966817 - It should be possible to create a button without an icon, using text instead

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

It should be possible to create a text button, instead of an icon button I think.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

As far as I know is not the direction UX wants, and we should create custom toolbaritem instead of toolbarbutton, and it seems that fx-team is not particularly happy about that,  but asking is not harming anyone.

I'm also afraid that just text button could be messed up a bit the navbar – they will be naturally wider than icon's button – and if we let the text to be updated dynamically like the icon, we'll end up to have resizing navbar all the time, and it's something we do not want to have. Therefore, we should specify `width` as widget or something like that, and the it could probably makes sense have different classes (e.g. TextButton?).
As compromise, in order to avoid the problems on navbar, we could makes this type of buttons only for Toolbar's API, like ui/frame at the moment: so you can actually create text button, but only in custom toolbar.

So, first thing first, UX: Stephen, what do you think?

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

What happens atm if we use an image that is say 100px wide and 50px in height?

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

It should be automatically resize, at least on height. Because we drop the `size` property, it won't probably resize on `width` and we should fix it. Officially, we support only square buttons.

Comment 4

[Stephen Horlander [:shorlander]]

While I understand that this might be desirable sometimes, part of the goal is creating a consistent and predictable experience for adding toolbar items.

Comment 5

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I agree with Stephen.