Closed
Bug 966832
Opened 11 years ago
Closed 11 years ago
[User story] Add video resolution to camera settings
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: skasetti, Assigned: gjyothiprasad, NeedInfo)
References
Details
(Whiteboard: [fxos:media])
User Story
1. As a user, I want to see video resolution in the settings menu of the camera 2. As a user, I want to be able to set the video resolution to the following values: HD 1280x720, QCGA 320x240 or QCIF 176x144
Attachments
(1 obsolete file)
No description provided.
Reporter | ||
Updated•11 years ago
|
User Story: (updated)
Whiteboard: [fxos:media]
Comment 1•11 years ago
|
||
Prasad! Please check the user stories and update the current status.
Assignee: nobody → gjyothiprasad
Current status of Implementation:
1. Changing video profile based on the value selected from setting menu - Done and Tested
2. When video recording starts, preview size should be changed to the size of selected video profile and preview size should be change back to an earlier value when recording stopped - under progress
Assignee | ||
Comment 3•11 years ago
|
||
Hi David,
This patch if for changing video resolutions when options in settings menu is changed. Since this is work in progress patch, we did not include test codes.
Attachment #8379685 -
Flags: review?(dflanagan)
Comment 4•11 years ago
|
||
Comment on attachment 8379685 [details]
Pointer to Pull Request.html
Asking Diego and Marcos for their feedback on this WIP as well.
Attachment #8379685 -
Flags: feedback?(wilsonpage)
Attachment #8379685 -
Flags: feedback?(dmarcos)
Comment 5•11 years ago
|
||
Diego and Wilson I mean :-)
Comment 6•11 years ago
|
||
We too have implemented this functionality. As this has always been marked as a Mozilla item, and is tightly coupled to the evolving settings framework, I suggest we use the Mozilla implementation.
Comment 7•11 years ago
|
||
Comment on attachment 8379685 [details]
Pointer to Pull Request.html
Clearing the review request based on comment #6
Attachment #8379685 -
Flags: review?(dflanagan)
Comment 8•11 years ago
|
||
Comment on attachment 8379685 [details]
Pointer to Pull Request.html
This patch is now obsolete.
Attachment #8379685 -
Attachment is obsolete: true
Attachment #8379685 -
Flags: feedback?(wilsonpage)
Attachment #8379685 -
Flags: feedback?(dmarcos)
Comment 9•11 years ago
|
||
Diego, Update the bug with the right PR for David's review (it is under review as part of another bug)
Flags: needinfo?(dmarcos)
Updated•11 years ago
|
Whiteboard: [fxos:media] → [fxos:media] [Land on Branch ETA 3/7]
Comment 10•11 years ago
|
||
This is being implemented as part of bug 980599 (Currently under review)
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 11•11 years ago
|
||
flagging for ux reviews - feature landed on "camera-new-features" branch only as 3/17
Flags: needinfo?(tshakespeare)
Flags: needinfo?(amlee)
Comment 12•11 years ago
|
||
I'm not sure what the issue is - I'm syncing the "camera-new-features" branch, but I'm not seeing any resolution options in the settings menu.
Comment 13•11 years ago
|
||
We will need the patch to review the UI for resolution settings for this bug. Can you please attach it?
Thanks
Flags: needinfo?(amlee) → needinfo?(gjyothiprasad)
Comment 14•11 years ago
|
||
I'm looking at the dual-shutter branch in Hyunacho's repo. Please let me know if this is incorrect.
My comments would be:
- the title of the video resolution sub-menu should be title case (i.e. Video Resolution)
- we should use a lower case x instead of the symbol that is being used (e.g. 2592x1944)
Unless we are going to have more than one resolution, it seems odd to offer a menu for a single option.
Flags: needinfo?(tshakespeare)
Updated•11 years ago
|
blocking-b2g: --- → 1.4+
Whiteboard: [fxos:media] [Land on Branch ETA 3/7] → [fxos:media]
Comment 15•11 years ago
|
||
Nothing in this bug ever landed in the tree, so there is nothing here that needs to be uplifted to v1.4.
Comment 16•11 years ago
|
||
Removing the 1.4+ flag since there is nothing to uplift here.
blocking-b2g: 1.4+ → ---
Updated•11 years ago
|
Flags: needinfo?(dmarcos)
You need to log in
before you can comment on or make changes to this bug.
Description
•