Closed
Bug 966836
Opened 10 years ago
Closed 10 years ago
[User story] Set ISO mode to auto
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(blocking-b2g:1.4+, b2g-v1.4 fixed)
Tracking | Status | |
---|---|---|
b2g-v1.4 | --- | fixed |
People
(Reporter: skasetti, Assigned: singhashish1887)
References
Details
(Whiteboard: [fxos:media])
User Story
As a user, I want the ISO mode be set to auto always if the device supports ISO
Attachments
(1 file, 5 obsolete files)
No description provided.
Reporter | ||
Updated•10 years ago
|
User Story: (updated)
Comment 1•10 years ago
|
||
Ashish! Please check the user stories and update the current status.
Assignee: nobody → singhashish1887
Assignee | ||
Comment 2•10 years ago
|
||
Once Gecko API is available we will implement ISO.
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8386506 -
Flags: review?(wilsonpage)
Comment 4•10 years ago
|
||
Will r+ once small nits addressed.
Updated•10 years ago
|
Target Milestone: --- → 1.4 S3 (14mar)
Comment 5•10 years ago
|
||
Before we land this, there needs to be something in config/app.js that we can switch this off with at build time. Exactly the same as with the whitebalance patch.
Flags: needinfo?(singhashish1887)
Comment 6•10 years ago
|
||
We need a build time configuration option to turn it off and on (per feature basis)
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(singhashish1887)
Assignee | ||
Comment 7•10 years ago
|
||
code is updated as per Wilson comment. We are working to make it build time configuration. there is same issue with HDR and White balance also
Assignee | ||
Updated•10 years ago
|
Attachment #8386506 -
Attachment is obsolete: true
Attachment #8386506 -
Flags: review?(wilsonpage)
Assignee | ||
Comment 8•10 years ago
|
||
Attachment #8387507 -
Flags: review?(wilsonpage)
Assignee | ||
Comment 9•10 years ago
|
||
build configuration is added.In js/config/apps.js we can disable the ISO mode making true isDisable flag.
Comment 10•10 years ago
|
||
Comment on attachment 8387507 [details] [review] Pull Request (camera-dev) Almost there. Comment inline on Github.
Attachment #8387507 -
Flags: review?(wilsonpage) → review-
Assignee | ||
Updated•10 years ago
|
Attachment #8387507 -
Attachment is obsolete: true
Assignee | ||
Comment 11•10 years ago
|
||
Updated as per Wilson's comments. Open for review
Attachment #8388003 -
Flags: review?(wilsonpage)
Updated•10 years ago
|
Attachment #8388003 -
Flags: review?(wilsonpage) → review+
Assignee | ||
Comment 12•10 years ago
|
||
Wilson Please review the UT cases for ISO
Attachment #8389017 -
Flags: review?(wilsonpage)
Assignee | ||
Comment 13•10 years ago
|
||
Attachment #8389247 -
Flags: review?(wilsonpage)
Attachment #8389247 -
Flags: review?(dflanagan)
Comment 14•10 years ago
|
||
Comment on attachment 8389247 [details] [review] Pull Request(Camera-new-feature) With UT This patch is very similar to the white balance patch. The tests are inadequate, but r+ to land it assuming that the tests pass. Also, I'd like someone to test manually that it works even on devices that do not have the required gecko patch to support ISO mode. That is, I want to be sure that this patch does not break phones running older versions of gecko.
Attachment #8389247 -
Flags: review?(dflanagan) → review+
Comment 15•10 years ago
|
||
Comment on attachment 8389247 [details] [review] Pull Request(Camera-new-feature) With UT r- due to incorrect ISO string values.
Updated•10 years ago
|
Attachment #8389247 -
Flags: review-
Comment 16•10 years ago
|
||
Mike's r- affects a test and is trivial to address. Justin or Diego: do either of you want to take this just to get it done and landed? Being forced to fix the test will allow you to set the file modes back to 644, which would be nice to do anyway.
Flags: needinfo?(jdarcangelo)
Flags: needinfo?(dmarcos)
Comment 17•10 years ago
|
||
Attachment #8388003 -
Attachment is obsolete: true
Attachment #8389017 -
Attachment is obsolete: true
Attachment #8389247 -
Attachment is obsolete: true
Attachment #8389017 -
Flags: review?(wilsonpage)
Attachment #8389247 -
Flags: review?(wilsonpage)
Attachment #8389410 -
Flags: review?(dflanagan)
Flags: needinfo?(jdarcangelo)
Flags: needinfo?(dmarcos)
Comment 18•10 years ago
|
||
Comment on attachment 8389410 [details] [review] pull-request (camera-new-features) Got r+ from djf on IRC. Landing now.
Attachment #8389410 -
Flags: review?(dflanagan) → review+
Comment 19•10 years ago
|
||
Landed in camera-new-features: https://github.com/mozilla-b2g/gaia/commit/cb64897a8263b7dfa67da6cbb1dec8963b8c9bd7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 21•10 years ago
|
||
We don't have any options in the settings to change ISO; it's always set to Auto so I'm not quite sure how to test this.
Comment 22•10 years ago
|
||
There's nothing to test here on the UX or visual side.
Flags: needinfo?(tshakespeare)
Flags: needinfo?(amlee)
Updated•10 years ago
|
blocking-b2g: --- → 1.4+
Updated•10 years ago
|
status-b2g-v1.4:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•