966867 - Increasing delay in web audio output on systems with native sample rate > 44100

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P1)

Description

[Karl Tomlinson (:karlt)]

Attachment: beeps.html

On a system with native audio sample rate of 48000:

1. Start browser.
2. load testcase.
3. click "Beep".
4. wait a few seconds.
5. click "Beep" again.

ER: similar response time for each click.

AR: response times are increasing.

I don't know why PA doesn't always return the same rate on my system, but sometimes it says 48000, and I see this bug.

Comment 1

[Karl Tomlinson (:karlt)]

Regression from https://hg.mozilla.org/integration/mozilla-inbound/rev/bc103864507b
Compare https://hg.mozilla.org/integration/mozilla-inbound/rev/fa872452b89d
to see the bug.

Comment 2

[Karl Tomlinson (:karlt)]

A debug build catches this as:

###!!! ASSERTION: Something went wrong with rounding to block boundaries: 't == aTo', file /home/karl/moz/dev/content/media/MediaStreamGraph.cpp, line 1104

Assertion failure: n->SampleRate() == nextStream->SampleRate() (All AudioNodeStreams in the graph must have the same sampling rate), at /home/karl/moz/dev/content/media/MediaStreamGraph.cpp:1222

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: don't overwrite preferred sample rate with default

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: use internal linkage for GetSampleRateForAudioContext

Comment 5

[Karl Tomlinson (:karlt)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce582b4aa4a1
https://hg.mozilla.org/integration/mozilla-inbound/rev/db60f1d540c4

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce582b4aa4a1
https://hg.mozilla.org/mozilla-central/rev/db60f1d540c4

Comment 7

[Carsten Book [:Tomcat]]

correcting target milestone, sorry for the bugmail spam