966873 - MediaStreamGraph keeps consuming CPU for AudioNodes in BFCache when not connected to destination

Status: RESOLVED DUPLICATE of bug 815492

(Core :: Web Audio, defect, P2)

Description

[Karl Tomlinson (:karlt)]

Attachment: convolved-chord-analysis.html

+++ This bug was initially created as a clone of Bug #941873 +++

Load this in a tab and then load another page in the same tab.

Expected results: cpu drops after loading the second page.
Actual: cpu use continues for many minutes.

FWIW Chrome behaves as expected.

Comment 1

[Andrea Marchesini [:baku]]

It seems that this bug is already fixed. Or at least I cannot reproduce this issue with the latest nightly. The CPU goes down immediately after the changing of the content in the same tab.

Comment 2

[Paul Adenot (:padenot)]

That's because I made it so that AudioContext::Suspend is called from nsGlobalWindow::SuspendTimeouts, that is called when the page is changed.

AudioContext::Suspend (among other things) moves all the MediaStreams that belong to the suspended AudioContext to a separate array (different from MediaStreamGraphImpl::mStreams, which is the array of streams to be processed). Then the AudioContext is collected some time after.

Comment 3

[Andrea Marchesini [:baku]]

Does it mean that this bug is fixed? Or do we have to do something more?

Comment 4

[Paul Adenot (:padenot)]

I think it's fixed, yes.

Comment 5

[Andrea Marchesini [:baku]]

I'm not sure this is the correct bug ID.

Comment 6

[Karl Tomlinson (:karlt)]

Yes, I don't think it was bug 815492 that fixed this, but good to know it is fixed, thanks.