Closed Bug 966913 Opened 6 years ago Closed 6 years ago

UITour: Hide the close button in the info panel until the extra behaviour is implemented

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 29

People

(Reporter: Unfocused, Assigned: Unfocused)

References

Details

Attachments

(1 file)

Turns out that close button in the panel can break the update tour page, as it doesn't yet send a callback when it's clicked. Lets hide it for now, until we have at least the callback implemented.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attached patch Patch v1Splinter Review
visibility:hidden so it's the most minimal patch that doesn't affect the layout of the panel (display:none would have).
Attachment #8369343 - Flags: review?(gijskruitbosch+bugs)
Attachment #8369343 - Flags: review?(gijskruitbosch+bugs) → review+
remote:   https://hg.mozilla.org/integration/fx-team/rev/bf25e29dc677
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/bf25e29dc677
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Verified as fixed using the following environment:

FF 29
Build id:20140305004002
OS:Ubuntu 12.04 x86, Max Os x 10.8.5, Win 7 x64
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.