Rocketbar search results are including contacts, but shouldn't be

RESOLVED FIXED

Status

Firefox OS
Gaia::Search
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jsmith, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
daleharvey
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
Per a discussion with Peter, the rocketbar should not be showing contacts in the rocketbar search results. Right now, if you have a contact added & you search for it in the rocketbar, you will find it.
(Reporter)

Updated

4 years ago
Blocks: 946452
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8369380 [details] [review]
Github pull request
(Assignee)

Comment 2

4 years ago
Comment on attachment 8369380 [details] [review]
Github pull request

Hey Dale - 

Could you review this if you have a minute? I would rather keep the code around and simply disable contacts for the time being. Let me know what you think.
Attachment #8369380 - Flags: review?(dale)
Comment on attachment 8369380 [details] [review]
Github pull request

https://github.com/mozilla-b2g/gaia/commit/8ea1ff3f509918039048e57da4e6803ed2e8c0cf

Would like to see this back in at some point
Attachment #8369380 - Flags: review?(dale) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.