Closed Bug 966942 Opened 7 years ago Closed 7 years ago

Cu.cloneInto fails cloning nsIDOMPaymentRequestInfo

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch payment.patch (obsolete) — Splinter Review
Still waiting for try results.
Comment on attachment 8369461 [details] [diff] [review]
payment.patch

https://tbpl.mozilla.org/?tree=Try&rev=997c222c6cbc
Attachment #8369461 - Flags: review?(ferjmoreno)
Attachment #8369461 - Flags: review?(bzbarsky)
Comment on attachment 8369461 [details] [diff] [review]
payment.patch

Why do we even need the nsIDOMPaymentRequestInfo dictionary?  Seems unused...

r=me with that nuked as well, as I suspect is can be.
Attachment #8369461 - Flags: review?(bzbarsky) → review+
Comment on attachment 8369461 [details] [diff] [review]
payment.patch

Review of attachment 8369461 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Andrea!

You still need to remove PaymentRequestInfo.js from moz.build, manifest and package-installer.in files

https://mxr.mozilla.org/mozilla-central/search?string=PaymentRequestInfo
Attachment #8369461 - Flags: review?(ferjmoreno)
Attached patch payment.patchSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=3d8288652f28
Attachment #8369461 - Attachment is obsolete: true
Attachment #8369999 - Flags: review?(ferjmoreno)
Attachment #8369999 - Flags: review?(ferjmoreno) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/67c9d01668df
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Depends on: 969654
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.